Skip to content

Review Comments Addressed #310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dragonfly91 merged 3 commits into from
Apr 27, 2016
Merged

Review Comments Addressed #310

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6e8c3fa
Moved RmClient to base cmdlet class
Apr 27, 2016
3f90bde
Updated output type of cmdlets to match the possible outputs
Apr 27, 2016
43484d5
Merge dev1
mkherani Apr 27, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...ds.RecoveryServices.Backup/Cmdlets/Container/GetAzureRmRecoveryServicesBackupContainer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ namespace Microsoft.Azure.Commands.RecoveryServices.Backup.Cmdlets
/// <summary>
/// Get list of containers
/// </summary>
[Cmdlet(VerbsCommon.Get, "AzureRmRecoveryServicesBackupContainer"), OutputType(typeof(ContainerBase))]
[Cmdlet(VerbsCommon.Get, "AzureRmRecoveryServicesBackupContainer"), OutputType(typeof(ContainerBase), typeof(IList<ContainerBase>))]
public class GetAzureRmRecoveryServicesBackupContainer : RecoveryServicesBackupCmdletBase
{
[Parameter(Mandatory = true, Position = 1, HelpMessage = ParamHelpMsgs.Container.ContainerType)]
Expand Down
2 changes: 1 addition & 1 deletion ...veryServices.Backup/Cmdlets/Container/GetAzureRmRecoveryServicesBackupManagementServer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ namespace Microsoft.Azure.Commands.RecoveryServices.Backup.Cmdlets
/// <summary>
/// Get list of containers
/// </summary>
[Cmdlet(VerbsCommon.Get, "AzureRmRecoveryServicesBackupManagementServer"), OutputType(typeof(BackupEngineBase))]
[Cmdlet(VerbsCommon.Get, "AzureRmRecoveryServicesBackupManagementServer"), OutputType(typeof(BackupEngineBase), typeof(IList<BackupEngineBase>))]
public class GetAzureRmRecoveryServicesBackupManagementServer : RecoveryServicesBackupCmdletBase
{
[Parameter(Mandatory = false, Position = 1, HelpMessage = ParamHelpMsgs.Container.Name)]
Expand Down
2 changes: 1 addition & 1 deletion ...kup/Commands.RecoveryServices.Backup/Cmdlets/Item/GetAzureRmRecoveryServicesBackupItem.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ namespace Microsoft.Azure.Commands.RecoveryServices.Backup.Cmdlets
/// <summary>
/// Get list of items
/// </summary>
[Cmdlet(VerbsCommon.Get, "AzureRmRecoveryServicesBackupItem", DefaultParameterSetName = GetItemsForContainerParamSet), OutputType(typeof(ItemBase))]
[Cmdlet(VerbsCommon.Get, "AzureRmRecoveryServicesBackupItem", DefaultParameterSetName = GetItemsForContainerParamSet), OutputType(typeof(ItemBase), typeof(IList<ItemBase>))]
public class GetAzureRmRecoveryServicesBackupItem : RecoveryServicesBackupCmdletBase
{
internal const string GetItemsForContainerParamSet = "GetItemsForContainer";
Expand Down
2 changes: 1 addition & 1 deletion ...ckup/Commands.RecoveryServices.Backup/Cmdlets/Jobs/GetAzureRmRecoveryServicesBackupJob.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ namespace Microsoft.Azure.Commands.RecoveryServices.Backup.Cmdlets
/// <summary>
/// Get list of jobs
/// </summary>
[Cmdlet(VerbsCommon.Get, "AzureRmRecoveryServicesBackupJob"), OutputType(typeof(JobBase))]
[Cmdlet(VerbsCommon.Get, "AzureRmRecoveryServicesBackupJob"), OutputType(typeof(JobBase), typeof(IList<JobBase>))]
public class GetAzureRmRecoveryServicesBackupJob : RecoveryServicesBackupCmdletBase
{
[Parameter(Mandatory = false, HelpMessage = ParamHelpMsgs.Job.StatusFilter, Position = 1)]
Expand Down
2 changes: 1 addition & 1 deletion ...kup/Commands.RecoveryServices.Backup/Cmdlets/Jobs/WaitAzureRmRecoveryServicesBackupJob.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@

namespace Microsoft.Azure.Commands.RecoveryServices.Backup.Cmdlets
{
[Cmdlet("Wait", "AzureRmRecoveryServicesBackupJob"), OutputType(typeof(JobBase))]
[Cmdlet("Wait", "AzureRmRecoveryServicesBackupJob"), OutputType(typeof(JobBase), typeof(IList<JobBase>))]
public class WaitAzureRmRecoveryServicesBackupJob : RecoveryServicesBackupCmdletBase
{
[Parameter(Mandatory = true, HelpMessage = ParamHelpMsgs.Job.WaitJobOrListFilter, ValueFromPipeline = true, Position = 1)]
Expand Down
2 changes: 1 addition & 1 deletion ...vices.Backup/Cmdlets/ProtectionPolicy/GetAzureRmRecoveryServicesBackupProtectionPolicy.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ namespace Microsoft.Azure.Commands.RecoveryServices.Backup.Cmdlets
/// Get list of protection policies
/// </summary>
[Cmdlet(VerbsCommon.Get, "AzureRmRecoveryServicesBackupProtectionPolicy", DefaultParameterSetName = NoParamSet),
OutputType(typeof(PolicyBase))]
OutputType(typeof(PolicyBase), typeof(IList<PolicyBase>))]
public class GetAzureRmRecoveryServicesBackupProtectionPolicy : RecoveryServicesBackupCmdletBase
{
protected const string PolicyNameParamSet = "PolicyNameParamSet";
Expand Down
2 changes: 1 addition & 1 deletion ...vices.Backup/Cmdlets/ProtectionPolicy/SetAzureRmRecoveryServicesBackupProtectionPolicy.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ public override void ExecuteCmdlet()

IPsBackupProvider psBackupProvider = providerManager.GetProviderInstance(
Policy.WorkloadType,
Policy.BackupManagementType);
Policy.BackupManagementType);
ProtectionPolicyResponse policyResponse = psBackupProvider.ModifyPolicy();
WriteDebug("ModifyPolicy http response from service: " +
policyResponse.StatusCode.ToString());
Expand Down
2 changes: 1 addition & 1 deletion ...eryServices.Backup/Cmdlets/RecoveryPoint/GetAzureRmRecoveryServicesBackupRecoveryPoint.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@

namespace Microsoft.Azure.Commands.RecoveryServices.Backup.Cmdlets
{
[Cmdlet(VerbsCommon.Get, "AzureRmRecoveryServicesBackupRecoveryPoint"), OutputType(typeof(RecoveryPointBase))]
[Cmdlet(VerbsCommon.Get, "AzureRmRecoveryServicesBackupRecoveryPoint"), OutputType(typeof(RecoveryPointBase), typeof(IList<RecoveryPointBase>))]
Copy link

@mkherani mkherani Apr 27, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line break :)

public class GetAzureRmRecoveryServicesBackupRecoveryPoint : RecoveryServicesBackupCmdletBase
{
internal const string DateTimeFilterParameterSet = "DateTimeFilter";
Expand Down