Skip to content

Conversation

pwolfram
Copy link
Contributor

@pwolfram pwolfram commented Nov 3, 2016

Continuous integration using pytest will help us avoid bugs and ensure that design objectives are being met via test.

This merge adds the capability for Travis CI to run py.test to ensure that tests are passing.

@pwolfram
Copy link
Contributor Author

pwolfram commented Nov 3, 2016

@xylar, I'll let you know when this is setup correctly

@pwolfram
Copy link
Contributor Author

pwolfram commented Nov 3, 2016

@xylar and @mark-petersen, this is ready to review. We pass on python 2.7 but not on python 3.5. This begs the question of which version of python we should support for the long term. See issue #43

@pwolfram
Copy link
Contributor Author

pwolfram commented Nov 3, 2016

Note, I could remove 3.5 for now so that the CI for our current repo passes. This may be the way to go and I'll do this unless there are objections.

@pwolfram pwolfram mentioned this pull request Nov 3, 2016
1 task
@pwolfram
Copy link
Contributor Author

pwolfram commented Nov 3, 2016

Note, if this passed pytest we would have a green check mark.

@xylar
Copy link
Collaborator

xylar commented Nov 3, 2016

@pwolfram, I think you should take out the python 3.5 checks for now. We can add it back after we have altered the repo to support python 3.5 (or as part of that transition, since it would be a helpful way of checking if we've done things right).

@xylar
Copy link
Collaborator

xylar commented Nov 3, 2016

@pwolfram, can you either explain here a bit more about how this works or point me to some simple documentation (if such a thing exists) that you used to know how to set this up? I'd like to understand what happens in the GitHub repo vs. what happens on the travis-ci.org. How is the script py.test assembled or where does it reside? What does that script look like?

@pwolfram
Copy link
Contributor Author

pwolfram commented Nov 3, 2016

@xylar, py.test is equivalent to py.test and is just how the testing suite is being ran. I just followed xarray's approach and the travis-ci.org quick-start documentation. I'm not doing anything fancy from here otherwise.

@pwolfram
Copy link
Contributor Author

pwolfram commented Nov 3, 2016

@xylar, I've removed the 3.5 test as requested for now. It isn't too hard to add it back.

@pwolfram
Copy link
Contributor Author

pwolfram commented Nov 3, 2016

@xylar, as far as I'm concerned this can be merged now. @mark-petersen, here is both an implementation and example of how this works. The only thing that needed to be done beside this code was turning on the travis-ci switch for this repo at https://travis-ci.org/profile/MPAS-Dev

@xylar
Copy link
Collaborator

xylar commented Nov 3, 2016

py.test is equivalent to pytest and is just how the testing suite is being ran. I just followed xarray's approach and the travis-ci.org quick-start documentation. I'm not doing anything fancy from here otherwise.

Ah, I see. That makes sense. then.

@xylar xylar merged commit de7f0a0 into MPAS-Dev:develop Nov 3, 2016
@pwolfram pwolfram deleted the addsCI branch November 3, 2016 19:19
@xylar
Copy link
Collaborator

xylar commented Nov 3, 2016

Nice! @pwolfram, don't forget to delete your remote branch since I can't.

@xylar
Copy link
Collaborator

xylar commented Nov 3, 2016

Oops, sorry! I missed that the don't merge flag was still on. Let me know if you wanted to make more changes.

@pwolfram
Copy link
Contributor Author

pwolfram commented Nov 3, 2016

No problem @xylar, I did realize I forgot the CI badge for the readme, however. So we need to add that in, but that isn't a big deal.

@pwolfram
Copy link
Contributor Author

pwolfram commented Nov 3, 2016

See #44

@jhkennedy jhkennedy mentioned this pull request Nov 29, 2017
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants