Rename cice to seaice #326

xylar · 2018-04-06T14:35:04Z

...everywhere except where used by ncclimo and in namelist and streams files in config files for existing E3SM runs.

Following @akturner's work to rename MPAS-Seaice (from MPAS-CICE), we need to make the same update in MPAS-Analysis. In practice this affects relatively few parts of the code because output file names from E3SM runs are read in from the streams file and we don't happen to use any namelist options that included cice in the name.

xylar · 2018-04-06T14:41:39Z

@akturner and @milenaveneziani, it would be good to test on a new E3SM run that includes the name change. I would be happy to run a QU240 G case and test with the results, assuming the current master branch of e3sm would produce the desired result. @akturner, is that the case?

One other thing that needs to be tested is if existing runs (before this change) still work as long as we explicitly give the old names for the namelist and streams files (as I have done in this PR). I will do some testing but would appreciate some from you, @milenaveneziani, if you're able.

One other bit of cleanup that we could include in this PR is that some of the runs we refer to in the example config files are no longer available (archive or deleted by @golaz). We will need to choose some newer runs as a substitute, probably from the v1 DECK runs currently being performed. I'll work on this when I can.

milenaveneziani · 2018-04-09T16:16:07Z

@akturner: will the change to MPAS-Seaice go in before the release?
I am not worried about MPAS-Analysis, but rather about a-prime, which is a bit more involving to change (and is also a software widely used by the coupled team, so we don't want to break it).

akturner · 2018-04-09T16:31:48Z

@milenaveneziani: I believe so, Jon can confirm @jonbob: Jon has confirmed, this is going into the release.

akturner · 2018-04-09T16:45:30Z

@xylar: Not in master yet, this is the PR to do so: E3SM-Project/E3SM#2229

xylar · 2018-04-09T16:50:45Z

Thanks for the clarification. @milenaveneziani, I think an a-prime PR should be prepared to handle this ASAP. I believe the current MPAS-Analysis would work unchanged with this change so A-Prime should be able to be updated to support the change without this PR.

I also think it would be easy to create a version of A-Prime that is backwards compatible so I don't see any downside to addressing this before E3SM-Project/E3SM#2229 gets merged.

milenaveneziani · 2018-04-09T16:54:01Z

well, but we need at least a E3SM test run for a-prime. So things have to move in parallel with E3SM-Project/E3SM#2229, I think.

xylar · 2018-04-09T17:00:11Z

This really isn't the right place for this discussion. Let's move to the issue I created in A-Prime.

xylar · 2018-04-16T16:45:30Z

@akturner and @jonbob, what is the status of the MPAS-Seaice rename? Can this be merged now? It should work with both the old and the new naming conventions so I don't see any downside.

xylar · 2018-04-16T16:46:00Z

@milenaveneziani, same question to you I guess.

akturner · 2018-04-16T19:23:17Z

Hi, So I'm a little confused what Rob Jacob has actually done. I think he's allowed the changes to the namelist and streams files but not other ones. If this supports the old and new I think we should proceed with this, because we plan to change the output with v2.1. Is that ok?

akturner

I don't have a good enough understanding of the code to approve the actual code changes. If this supports a mixture of the old and new names (Rob only allowed some of the changes) then I approve.

milenaveneziani · 2018-04-16T19:27:53Z

streams and namelist filenames have changed for sure.
I am not sure about filenames.

What I know hasn't changed are the compset names, which don't matter for this PR, of course.

milenaveneziani · 2018-04-16T19:31:21Z

README.md

-      * `mpascice.rst.0002-01-01_00000.nc` (or any other mpas-cice restart
+  * mpas-seaice files:
+      * `mpasseaice.hist.am.timeSeriesStatsMonthly.*.nc`
+      * `mpasseaice.rst.0002-01-01_00000.nc` (or any other mpas-seaice restart


For the time being, I would keep the old filenames in there as well. We can remove them all together when the change to MPAS-seaice is definite.

milenaveneziani · 2018-04-16T19:31:44Z

README.md

-      * `streams.cice`
-      * `mpas-cice_in`
+      * `streams.seaice`
+      * `mpas-seaice_in`


same goes with these.

xylar · 2018-04-16T20:28:03Z

Okay, sounds good. I can make clear that some runs will have the old (cice) name while we expect newer runs to have only seaice.

xylar · 2018-04-17T10:04:11Z

@milenaveneziani, could you make sure the changes I made address your concerns?

milenaveneziani · 2018-04-17T14:27:55Z

@xylar, for some reason, I don't see the new changes.

xylar · 2018-04-17T14:31:29Z

I just amended the original commit.

xylar · 2018-04-17T14:31:54Z

README.md

+  * `mpascice.rst.0002-01-01_00000.nc`
+  * `streams.cice`
+  * `mpas-cice_in`
+


@milenaveneziani, here are the additions that you requested.

great thanks.

xylar · 2018-04-17T14:32:52Z

docs/mpasseaice.rst

-``streams.cice``, (even if they will not be written out --
-``output_interval=="none"``)::
+``streams.seaice`` or ``streams.cice`` in older E3SM runs, (even if they will
+not be written out -- ``output_interval=="none"``)::


@milenaveneziani, you didn't explicitly request this but I also made changes here and on line 17 above to reference older E3SM runs.

milenaveneziani · 2018-04-17T15:14:00Z

I will test this on an existing E3SM run today.
We could also test on a newer run for which we have write access in the run/ directory to create some links: maybe @vanroekel's high-res G-case?

xylar · 2018-04-17T15:41:30Z

The high-res G case seems like a heavy test. Maybe @darincomeau could help us create a mock-up of the name change on his low-res G case on Theta:
/projects/OceanClimate/dcomeau/20180328.GMPAS-IAF.T62_oEC60to30v3wLI.theta.GM600/run

darincomeau · 2018-04-17T15:51:01Z

@xylar sure - what did you have in mind? Did you want me to run this on the theta low-res G case as is, to test that it works with cice names? Or rename cice files to seaice, and test that? Or both?

milenaveneziani · 2018-04-17T16:00:53Z

@darincomeau: I think you can just create links for streams.seaice and mpassi_in to streams.cice and mpas-cice_in, respectively, and you should be done.

xylar · 2018-04-17T16:13:29Z

@darincomeau, yes, running as is on your run would not hurt. You will probably need to add the old names of the MPAS-Seaice namelist and streams files to your config file because the defaults have changed.

[input]
...
seaIceNamelistFileName = mpas-cice_in
seaIceStreamsFileName = streams.cice

Then, you could create the links above as @milenaveneziani says, though the correct names are:

mpas-seaice_in
streams.seaice

and you would remove (or edit) the two config entries above so it uses the new names.

(This is kind of a silly test because I'm sure it will work...)

darincomeau · 2018-04-17T18:25:45Z

@xylar , @milenaveneziani , I've just finished running this on my theta run with both mpas-cice_in, streams.cice and mpas-seaice_in, streams.seaice listed in the config file, and both ran without problem. Let me know if there's anything else you'd like me to test.

xylar · 2018-04-17T18:27:51Z

Glad to hear it. I think that should be it.

@milenaveneziani, can I merge or did you also want to test?

Everywhere except where used by ncclimo. Use old input and streams file names in config files for existing E3SM.

milenaveneziani

no, that's fine. go ahead.
Thanks @darincomeau.

xylar · 2018-04-17T20:51:55Z

Thanks!

xylar added in progress clean up labels Apr 6, 2018

xylar self-assigned this Apr 6, 2018

xylar requested review from akturner and milenaveneziani April 6, 2018 14:35

xylar removed the in progress label Apr 16, 2018

akturner reviewed Apr 16, 2018

View reviewed changes

milenaveneziani reviewed Apr 16, 2018

View reviewed changes

README.md

* `streams.cice`

* `mpas-cice_in`

* `streams.seaice`

* `mpas-seaice_in`

Copy link

Collaborator

milenaveneziani Apr 16, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same goes with these.

xylar force-pushed the cice_seaice_rename branch from 652b16f to c5abde7 Compare April 16, 2018 20:49

xylar mentioned this pull request Apr 17, 2018

Update to v0.7.5 in docs, setup and recipe #334

Merged

xylar commented Apr 17, 2018

View reviewed changes

Rename cice to seaice

c4f1d21

Everywhere except where used by ncclimo. Use old input and streams file names in config files for existing E3SM.

xylar force-pushed the cice_seaice_rename branch from c5abde7 to c4f1d21 Compare April 17, 2018 19:40

xylar added the priority label Apr 17, 2018

milenaveneziani approved these changes Apr 17, 2018

View reviewed changes

xylar merged commit 1be67f1 into MPAS-Dev:develop Apr 17, 2018

xylar deleted the cice_seaice_rename branch April 17, 2018 20:52

Rename cice to seaice #326

Rename cice to seaice #326

Uh oh!

Conversation

xylar commented Apr 6, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

xylar commented Apr 6, 2018

Uh oh!

milenaveneziani commented Apr 9, 2018

Uh oh!

akturner commented Apr 9, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

akturner commented Apr 9, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

xylar commented Apr 9, 2018

Uh oh!

milenaveneziani commented Apr 9, 2018

Uh oh!

xylar commented Apr 9, 2018

Uh oh!

xylar commented Apr 16, 2018

Uh oh!

xylar commented Apr 16, 2018

Uh oh!

akturner commented Apr 16, 2018

Uh oh!

akturner left a comment

Choose a reason for hiding this comment

Uh oh!

milenaveneziani commented Apr 16, 2018

Uh oh!

milenaveneziani Apr 16, 2018

Choose a reason for hiding this comment

Uh oh!

milenaveneziani Apr 16, 2018

Choose a reason for hiding this comment

Uh oh!

xylar commented Apr 16, 2018

Uh oh!

xylar commented Apr 17, 2018

Uh oh!

milenaveneziani commented Apr 17, 2018

Uh oh!

xylar commented Apr 17, 2018

Uh oh!

xylar Apr 17, 2018

Choose a reason for hiding this comment

Uh oh!

milenaveneziani Apr 17, 2018

Choose a reason for hiding this comment

Uh oh!

xylar Apr 17, 2018

Choose a reason for hiding this comment

Uh oh!

milenaveneziani commented Apr 17, 2018

Uh oh!

xylar commented Apr 17, 2018

Uh oh!

darincomeau commented Apr 17, 2018

Uh oh!

milenaveneziani commented Apr 17, 2018

Uh oh!

xylar commented Apr 17, 2018

Uh oh!

darincomeau commented Apr 17, 2018

Uh oh!

xylar commented Apr 17, 2018

Uh oh!

milenaveneziani left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

xylar commented Apr 17, 2018

Uh oh!

Reviewers

Assignees

Labels

xylar commented Apr 6, 2018 •

edited

Loading

akturner commented Apr 9, 2018 •

edited

Loading

akturner commented Apr 9, 2018 •

edited

Loading

milenaveneziani left a comment •

edited

Loading