-
Notifications
You must be signed in to change notification settings - Fork 53
Switch from relative to absolute imports #307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This follows from: #280 (comment) |
TestingI ran the QU240 test case I always use on my laptop. Once I got all the absolute imports right, everything worked as expected. |
@jhkennedy, I would suggest two tests if you are willing to review this PR:
Thanks! |
@xylar Happy to! I'll put it on my schedule for tomorrow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything, except two very small changes, looks good to me here!
Unfortunately, I'm not a member of the acme
group on Edison, so I had to run the tests on Titan. Other than a few errors from missing files (which look correct and not caused by this PR) everything ran smoothly and output the expected website.
The changes are just small formatting changes -- there are a couple of from
import statements that have two spaces.
mpas_analysis/shared/io/__init__.py
Outdated
from .utility import paths | ||
from .write_netcdf import write_netcdf | ||
from .mpas_reader import open_mpas_dataset, subset_variables | ||
from mpas_analysis.shared.io.namelist_streams_interface import NameList, \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are two spaces here after the from
@@ -1 +1 @@ | |||
from .remapper import Remapper | |||
from mpas_analysis.shared.interpolation.remapper import Remapper |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are two spaces here after the from
This is the recommended python standard.
e994934
to
87ff980
Compare
@jhkennedy, I’ve fixed the two formatting issues you found (thanks!). Let me know if there’s anything else before I merge. |
Looks good to me; merge on! |
Thanks, @jhkennedy. |
This is the recommended python philosophy: "explicit is better than implicit".