Skip to content

add basic accessibility support. #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 23, 2017
Merged

add basic accessibility support. #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d4014a0
add basic accessibility support.
brunano21 Dec 22, 2017
405503b
more accessibility.
brunano21 Dec 22, 2017
b23660c
Added `scope` attribute to `th` tags.
brunano21 Dec 22, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/components/header.template.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,13 @@ export const HEADER_TEMPLATE = `
<h4 class="title" [textContent]="dataTable.headerTitle"></h4>
<div class="button-panel">
<button type="button" class="btn btn-default btn-sm refresh-button"
(click)="dataTable.reloadItems()">
(click)="dataTable.reloadItems()"
[attr.aria-label]="dataTable.translations.headerReload" [title]="dataTable.translations.headerReload">
<span class="glyphicon glyphicon-refresh"></span>
</button>
<button type="button" class="btn btn-default btn-sm column-selector-button" [class.active]="columnSelectorOpen"
(click)="columnSelectorOpen = !columnSelectorOpen; $event.stopPropagation()" >
(click)="columnSelectorOpen = !columnSelectorOpen; $event.stopPropagation()"
[attr.aria-label]="dataTable.translations.headerColumnSelector" [title]="dataTable.translations.headerColumnSelector">
<span class="glyphicon glyphicon-list"></span>
</button>
<div class="column-selector-wrapper" (click)="$event.stopPropagation()">
Expand Down Expand Up @@ -40,4 +42,4 @@ export const HEADER_TEMPLATE = `
</div>
</div>
</div>
`;
`;
10 changes: 6 additions & 4 deletions src/components/row.template.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,11 @@ export const ROW_TEMPLATE = `
(dblclick)="dataTable.rowDoubleClicked(_this, $event)"
(click)="dataTable.rowClicked(_this, $event)"
>
<td [hide]="!dataTable.expandColumnVisible" (click)="expanded = !expanded; $event.stopPropagation()" class="row-expand-button">
<span class="glyphicon glyphicon-triangle-right" [hide]="expanded"></span>
<span class="glyphicon glyphicon-triangle-bottom" [hide]="!expanded"></span>
<td [hide]="!dataTable.expandColumnVisible">
<div tabindex="0" role="button" (click)="expanded = !expanded; $event.stopPropagation()" class="row-expand-button"
[attr.aria-expanded]="expanded" [title]="dataTable.translations.expandRow" [attr.aria-label]="dataTable.translations.expandRow">
<span class="glyphicon" [ngClass]="{'glyphicon-triangle-right': !expanded, 'glyphicon-triangle-bottom': expanded}" aria-hidden="true"></span>
</div>
</td>
<td [hide]="!dataTable.indexColumnVisible" class="index-column" [textContent]="displayIndex"></td>
<td [hide]="!dataTable.selectColumnVisible" class="select-column">
Expand All @@ -28,4 +30,4 @@ export const ROW_TEMPLATE = `
<div [ngTemplateOutlet]="dataTable.expandTemplate" [ngOutletContext]="{row: _this, item: item}"></div>
</td>
</tr>
`;
`;
Loading