Parse CDI subjects to individual entries #319
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 20344065907Details
💛 - Coveralls |
matt-bernhardt
approved these changes
Dec 18, 2025
Member
matt-bernhardt
left a comment
matt-bernhardt
left a comment
There was a problem hiding this comment.
Oh, nice - I had noticed this the other day.
Why are these changes being introduced: * CDI was the only source that used a single string with multiple subjects * Normalizing these to individual subjects improves consistency across sources Relevant ticket(s): * https://mitlibraries.atlassian.net/browse/USE-303 How does this address that need: * Updates the primo normaliztion to split subjects on ' ; ' delimiter * This should have no affect on Primo Alma data that does not use this format but should clean up the Primo CDI data Document any side effects to this change: * Our full record fixture was update to reflect the typical CDI data. The test was not changed as our new code modifies the data to match the previous expected result.
JPrevost
force-pushed
the
use-303-normalize-cdi-subjects
branch
from
7ff6b5d to
6b18d78
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes being introduced:
Relevant ticket(s):
How does this address that need:
Document any side effects to this change:
Developer
Accessibility
New ENV
Approval beyond code review
Additional context needed to review
E.g., if the PR includes updated dependencies and/or data
migration, or how to confirm the feature is working.
Code Reviewer
Code
added technical debt.
Documentation
(not just this pull request message).
Testing