-
Notifications
You must be signed in to change notification settings - Fork 211
Add Dutch translation #227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
|
Quick look the translations seem to be good on mobile rn so didnt have a proper look |
|
I could make some good changes as a Dutchie my self! May I do that? |
|
Yeah np, I'm from The Netherlands as well, but any improvements are always welcome! |
|
Alright will get to work then! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It’s a great translation! But here some improvements! Mainly the capital letters and rendering mistakes!
Edit: instead of “genereren” just “renderen”
-
Still to do!
-
Capital letters.
-
Translation oversights.
-
And some “Duidelijk makers!”
| "voxy.config.general.enabled.tooltip": "Schakelt voxy volledig in of uit", | ||
|
|
||
| "voxy.config.general.serviceThreads": "Service threads", | ||
| "voxy.config.general.serviceThreads.tooltip": "Aantal threads dat de ServiceThreadPool kan gebruiken", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe in parentheses: (Hoe de LoDs worden renderd).
| "voxy.config.title": "Voxy", | ||
|
|
||
| "voxy.config.general": "Algemeen", | ||
| "voxy.config.rendering": "Rendering", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be: Genereren.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well no genereren is generate. maybe "renderen" is better then rendering
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes! Thanks.
| "voxy.config.rendering": "Rendering", | ||
|
|
||
| "voxy.config.general.enabled": "Voxy inschakelen", | ||
| "voxy.config.general.enabled.tooltip": "Schakelt voxy volledig in of uit", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Voxy should always be with capital letter so: Schakelt Voxy volledig in of uit.
| "voxy.config.general.serviceThreads.tooltip": "Aantal threads dat de ServiceThreadPool kan gebruiken", | ||
|
|
||
| "voxy.config.general.useSodiumBuilder": "Sodium threads gebruiken", | ||
| "voxy.config.general.useSodiumBuilder.tooltip": "Gebruikt sodium builder threads als onderdeel van voxy's thread pool, kan stotteren en lag verminderen bij snel bewegen op hoge renderafstand", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also here voxy’s should be Voxy’s here, and it should be genereerafstand. From now on I’ll stop saying the capital letters, but they should still be changed!
| "voxy.config.general.ingest": "Chunk verwerking", | ||
| "voxy.config.general.ingest.tooltip": "Schakelt voxy's mogelijkheid om nieuwe chunks naar LoDs te converteren in of uit", | ||
|
|
||
| "voxy.config.general.rendering": "Voxy Rendering", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Genereren instead of rendering!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as said before i think renderen (or rendering even) is still better then genereren as this is about the rendering of the chunks not the generating/ingesting of the chunks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well they are loaded in so you can see them but… hey its just a translation don’t be hard about it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i put thumbsdown for the others as an indicator they should be changed to renderen or keep at rendering but genereren isnt the correct word
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, that’s valid. But why no explanation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cuz im tired just came out of a difficult exam and my brain forgor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because rendering is not a Dutch word.
| "voxy.config.general.renderDistance.tooltip": "Renderafstand van voxy in chunks", | ||
|
|
||
| "voxy.config.general.environmental_fog": "Omgevingsmist inschakelen", | ||
| "voxy.config.general.environmental_fog.tooltip": "Schakelt voxy omgevingsmist rendering in of uit", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of Rendering it should be genereren
| "voxy.config.general.environmental_fog": "Omgevingsmist inschakelen", | ||
| "voxy.config.general.environmental_fog.tooltip": "Schakelt voxy omgevingsmist rendering in of uit", | ||
|
|
||
| "voxy.config.general.render_fog": "Render mist inschakelen", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Genereer!
| "voxy.config.general.environmental_fog.tooltip": "Schakelt voxy omgevingsmist rendering in of uit", | ||
|
|
||
| "voxy.config.general.render_fog": "Render mist inschakelen", | ||
| "voxy.config.general.render_fog.tooltip": "Schakelt render mist effect in of uit", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also genereer!
| "voxy.config.general.render_fog": "Render mist inschakelen", | ||
| "voxy.config.general.render_fog.tooltip": "Schakelt render mist effect in of uit", | ||
|
|
||
| "voxy.config.general.render_statistics": "Render statistieken inschakelen", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also genereer!
| "voxy.config.general.render_fog.tooltip": "Schakelt render mist effect in of uit", | ||
|
|
||
| "voxy.config.general.render_statistics": "Render statistieken inschakelen", | ||
| "voxy.config.general.render_statistics.tooltip": "Schakel render statistieken in het F3 menu in, handig voor het opsporen van problemen" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here genereer!
|
@VodaCode-Official thanks for the suggestions! My feedback on your comments:
|
|
I was also looking ath the LoD one and didnt understand where that was supposed to go |
|
@untitledpng Glad that I could help! So here some more information or just opinions:
|
Add Dutch language support (nl_nl.json)
Adds Dutch translations for all Voxy config UI strings.
Changes:
src/main/resources/assets/voxy/lang/nl_nl.jsonwith Dutch translations for all config options and tooltips.