Skip to content

Separate internal APIs #3504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 108 commits into from
Mar 12, 2021
Merged

Separate internal APIs #3504

merged 108 commits into from
Mar 12, 2021

Conversation

@lbargaoanu
Copy link
Contributor

@lbargaoanu lbargaoanu commented Sep 21, 2020 •
edited
Loading

@lbargaoanu lbargaoanu force-pushed the explicit_expand branch 2 times, most recently from c6fbdff to e1ec3d1 Compare September 21, 2020 13:45
@lbargaoanu lbargaoanu force-pushed the explicit_expand branch 3 times, most recently from 07a680c to 7b2e7b3 Compare September 23, 2020 06:15
@lbargaoanu lbargaoanu added this to the v.nextMajor milestone Sep 23, 2020
@lbargaoanu lbargaoanu force-pushed the explicit_expand branch 3 times, most recently from 7de7364 to 0d369a2 Compare September 27, 2020 05:42
@lbargaoanu lbargaoanu force-pushed the explicit_expand branch 2 times, most recently from 76fd4bc to 8c20769 Compare September 28, 2020 10:11
@lbargaoanu lbargaoanu force-pushed the explicit_expand branch 2 times, most recently from 19ba0ce to 70f9b29 Compare October 1, 2020 11:10
lbargaoanu
lbargaoanu commented Oct 1, 2020
View reviewed changes
src/UnitTests/Constructors.cs Outdated
}
class Destination
{
public Destination(int value = 2) => Value = value;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

People want to say that the property Value is mapped because this constructor is used.

@lbargaoanu lbargaoanu force-pushed the explicit_expand branch 2 times, most recently from dbb1a95 to e12e236 Compare October 1, 2020 13:42
lbargaoanu
lbargaoanu commented Oct 5, 2020
View reviewed changes
src/AutoMapper/Configuration/MapperConfigurationExpression.cs

public IList<IObjectMapper> Mappers { get; }

public AdvancedConfiguration Advanced { get; } = new AdvancedConfiguration();
Copy link
Contributor Author

@lbargaoanu lbargaoanu Oct 5, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not exactly correct, but it seems reasonable to replace Advanced with Internal(), or use Advanced() instead. Easier to upgrade. If some setting is too important for that, we could move it in the public interface.

@lbargaoanu lbargaoanu force-pushed the explicit_expand branch 3 times, most recently from b96ea0b to f5d9191 Compare January 8, 2021 12:55
@lbargaoanu lbargaoanu force-pushed the explicit_expand branch 5 times, most recently from 87d06b1 to 6882b79 Compare January 10, 2021 08:27
@lbargaoanu lbargaoanu force-pushed the explicit_expand branch 3 times, most recently from d677e95 to 261e70b Compare January 14, 2021 12:59
@LuckyPennySoftware LuckyPennySoftware locked and limited conversation to collaborators Jan 27, 2021
@jbogard jbogard merged commit 9f2f160 into master Mar 12, 2021
@jbogard jbogard deleted the explicit_expand branch March 12, 2021 22:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jbogard jbogard jbogard approved these changes

Assignees

@jbogard jbogard

Labels

Improvement

Projects

None yet

Milestone

11.0.0

Development

Successfully merging this pull request may close these issues.

CreateProjection

2 participants

@lbargaoanu @jbogard