Skip to content

Conversation

marionbarker
Copy link
Contributor

Purpose

  • Update method for handling strings to String Catalogs (available as of Xcode 15)
  • Update Scripts for working with lokalise
  • Bring in new translations from lokalise
    • Some submodules had strings added, updated or removed
    • At lokalise, improve key handling
      • Duplicate keys were linked which provide translations across submodules for linked keys and minimizes future work by contributors
      • Keys that do not require translations were hidden from contributors
  • Update the testflight.md instructions - they were missing the requirement to manually add the time-sensitive requirement

@marionbarker marionbarker requested review from itsmojo and ps2 September 10, 2025 14:17
@marionbarker
Copy link
Contributor Author

Test

  • Successful build using Xcode 16.4 onto test phone running iOS 18.6.2
    • Spot check in French: main app is translated
      • Check that every CGM, Pump and Service shows up with included translation strings
  • Repeat build and spot check (with Italian) onto test phone running iOS 15
    • All was successful, except Mixpanel does not load on an iOS 15 device - not something we plan to modify
  • Successful Browser Build

Copy link
Contributor

@ps2 ps2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT! Thanks Marion!

@marionbarker marionbarker merged commit 58e3d99 into dev Sep 10, 2025
1 check passed
@marionbarker marionbarker deleted the convert_to_xcstrings_and_update branch September 10, 2025 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants