main branch: Use a special version of fastlane to enable Add Identifiers #286
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Method
The solution requires using a special version of fastlane 2.228.0 with PR 29596 applied along with a modification to the
fastlane/Fastfile
file.This uses a branch at the loopandlearn fork: https://github.com/loopandlearn/fastlane/tree/wip_2.228.0_pr29596
Details of updated files
See also PR #285 for the dev branch Add Identifier fix where this solution was initially implemented for Loop. This same method (regarding changes needed for items 1 and 2 below) also works for LoopFollow, LoopCaregiver, Trio, xDrip4iOS and iAPS.
Gemfile
file is modified to use the SHA of the custom branch mentioned above, runningbundle update fastlane
and then committing theGemfile
andGemfile.lock
files.fastlane/Fastfile
was modified according to the suggestion by @dnzxy which adds the "platform" variable to the configure_bundle_id function.USERNOTIFICATIONS_TIMESENSITIVE
is no longer supported, so this was removed from thefastlane/Fastfile
capabilities for the Loop IdentifierTest
The detailed testing for this PR is found in the next comment.