Skip to content

Conversation

@ppcuni
Copy link
Contributor

@ppcuni ppcuni commented Mar 7, 2023

No description provided.

@wada-at-live2d-com
Copy link
Contributor

wada-at-live2d-com commented Mar 17, 2023

Hi, @ppcuni

Sorry for the delay in getting back to you.

Please explain in the description of this pull request what the intent of this modification is.
We are unable to incorporate the modification in this situation for the following reasons.

  • It is undesirable to use OnDrawableRnederOrderDidChange and return it for the convenience of using this function.
    • In the following sections, CubismDynamicDrawableData.IsRenderOrderDirty is used to determine that there is a change, and then processing is done. Even if you return with OnDrawableRenderOrderDidChange, CubismRenderer.SwapMeshes will be called by setting swapMeshes flag to true afterwards, which may cause unnecessary processing.
    • // Update render order.
      if (data[i].IsRenderOrderDirty)
      {
      renderers[i].OnDrawableRenderOrderDidChange(data[i].RenderOrder);
      swapMeshes = true;
      }

Thanks.

@wada-at-live2d-com wada-at-live2d-com merged commit e87b9d3 into Live2D:develop Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants