Add method to know playing motion or not #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itoh-at-live2d-com
requested changes
Jun 28, 2019
| return false; | ||
| } | ||
|
|
||
| return _motionLayers[layerIndex].IsFinished; |
There was a problem hiding this comment.
IsFinishedはモーション再生の完了を示すフラグなので、
この実装の場合は、完了していると再生している状態になると思います。
意図通りの結果となっていますでしょうか？
There was a problem hiding this comment.
処理を誤っておりました。修正いたしました。
|
@koichiyamashita |
itoh-at-live2d-com
requested review from
itoh-at-live2d-com and
ono-at-live2d-com
itoh-at-live2d-com
approved these changes
Jun 28, 2019
|
Add a getter method |
|
@koichiyamashita |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CubismMotionController に「モーション再生中かどうか」を返すメソッドを追加しました。