Skip to content

Conversation

sergeytimoshin
Copy link
Contributor

No description provided.

Copy link
Contributor

coderabbitai bot commented Sep 1, 2025

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (1)
  • ai-review

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch sergey/forester-batched-cleanup

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sergeytimoshin sergeytimoshin marked this pull request as ready for review September 2, 2025 15:14
@ananas-block
Copy link
Contributor

The ci error in [examples-tests / system-programs (sdk-test-program, ["cargo-test-sbf -p sdk-test"])](https://github.com/Lightprotocol/light-protocol/actions/runs/17407986417/job/49417499842?pr=1928) should resolve with #1927

    Finished `release` profile [optimized] target(s) in 1m 10s
[2025-09-02T15:26:22.205090609Z ERROR cargo_build_sbf] Unable to get file metadata for /home/runner/work/light-protocol/light-protocol/target/sbpf-solana-solana/release/client_test.so: No such file or directory (os error 2)

Copy link
Contributor

@ananas-block ananas-block left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How will we measure perf going forward?

@sergeytimoshin
Copy link
Contributor Author

How will we measure perf going forward?

grafana dashboards with proper metrics, this log scrapping is too error-prone and ugly in general

@sergeytimoshin sergeytimoshin marked this pull request as draft September 4, 2025 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants