Skip to content

Conversation

@ananthsub
Copy link
Contributor

@ananthsub ananthsub commented May 19, 2021

What does this PR do?

Fixes #6286

To discuss: The PR currently enforces each trigger (every_n_train_steps, train_time_interval, every_n_val_epochs) to be mutually exclusive. This means if someone wants to checkpoint every N hours and every M train batches, they'd need to create two callbacks.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented May 19, 2021

Codecov Report

Merging #7613 (0f70c81) into master (485554c) will decrease coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #7613   +/-   ##
======================================
- Coverage      92%     92%   -0%     
======================================
  Files         198     198           
  Lines       12912   12930   +18     
======================================
+ Hits        11912   11914    +2     
- Misses       1000    1016   +16     

@ananthsub ananthsub added callback checkpointing Related to checkpointing ready PRs ready to be merged labels May 19, 2021
@ananthsub ananthsub enabled auto-merge (squash) May 19, 2021 20:47
@carmocca
Copy link
Contributor

Does this replace #7515?

What's the difference?

@ananthsub
Copy link
Contributor Author

Does this replace #7515?

What's the difference?

there's no difference. this was following up from our slack discussion as to whether the GPU tests were failing was because i was working off a branch in my fork vs in the lightning repo directly. since the base repo changed, i needed to create a new PR

@mergify mergify bot removed the has conflicts label May 19, 2021
@ananthsub ananthsub closed this May 19, 2021
auto-merge was automatically disabled May 19, 2021 22:22

Pull request was closed

@carmocca carmocca deleted the feat-ckpt-time-based-trigger branch May 19, 2021 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

callback checkpointing Related to checkpointing ready PRs ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support time-based checkpointing trigger

3 participants