Skip to content

Conversation

@fepegar
Copy link
Contributor

@fepegar fepegar commented May 19, 2021

What does this PR do?

Resolves #7595.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • [n/a] Did you write any new necessary tests? (not for typos and docs)
  • [n/a] Did you verify new and existing tests pass locally with your changes?
  • [n/a] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Copy link
Contributor

@carmocca carmocca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome project!

@carmocca carmocca added this to the v1.4 milestone May 19, 2021
@carmocca carmocca added the docs Documentation related label May 19, 2021
@carmocca carmocca enabled auto-merge (squash) May 19, 2021 20:43
@carmocca carmocca added the ready PRs ready to be merged label May 19, 2021
@codecov
Copy link

codecov bot commented May 19, 2021

Codecov Report

Merging #7612 (ab917d7) into master (7cdf036) will decrease coverage by 5%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #7612    +/-   ##
=======================================
- Coverage      92%     88%    -5%     
=======================================
  Files         197     197            
  Lines       12878   12874     -4     
=======================================
- Hits        11896   11312   -584     
- Misses        982    1562   +580     

@carmocca carmocca merged commit 485554c into Lightning-AI:master May 19, 2021
@fepegar
Copy link
Contributor Author

fepegar commented May 19, 2021

Thanks for reviewing, @carmocca, @ananthsub and @awaelchli.

For the record, I updated the changelog following the Geometric example: https://github.com/PyTorchLightning/pytorch-lightning/blob/master/CHANGELOG.md#added-9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation related example ready PRs ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add TorchIO tutorial to PyTorch Ecosystem examples

4 participants