Skip to content

Conversation

@carmocca
Copy link
Contributor

@carmocca carmocca commented May 18, 2021

What does this PR do?

1/n: #7590
Part of #7183

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes? (if necessary)
  • [n/a] Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • [n/a] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

@carmocca carmocca added this to the v1.4 milestone May 18, 2021
@carmocca carmocca self-assigned this May 18, 2021
@carmocca carmocca changed the title Unify current_fx_name and current_hook_fx_name Unify current_fx_name and current_hook_fx_name [2/n] May 18, 2021
@codecov
Copy link

codecov bot commented May 18, 2021

Codecov Report

Merging #7594 (f37c1ea) into master (608de6a) will decrease coverage by 0%.
The diff coverage is 94%.

@@          Coverage Diff           @@
##           master   #7594   +/-   ##
======================================
- Coverage      88%     88%   -0%     
======================================
  Files         197     197           
  Lines       12871   12868    -3     
======================================
- Hits        11325   11306   -19     
- Misses       1546    1562   +16     

@carmocca carmocca added the ready PRs ready to be merged label May 18, 2021
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@tchaton tchaton enabled auto-merge (squash) May 19, 2021 08:12
@mergify mergify bot removed the has conflicts label May 19, 2021
@tchaton tchaton merged commit 901b2ba into master May 19, 2021
@tchaton tchaton deleted the refactor/logger-connector-2 branch May 19, 2021 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready PRs ready to be merged refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants