Skip to content

Conversation

@Borda
Copy link
Collaborator

@Borda Borda commented May 6, 2021

What does this PR do?

as the title says towards to 1.4

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added the docs Documentation related label May 6, 2021
@Borda Borda added this to the v1.4 milestone May 6, 2021
@codecov
Copy link

codecov bot commented May 6, 2021

Codecov Report

Merging #7413 (9c21f51) into master (fbc8b20) will decrease coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #7413   +/-   ##
======================================
- Coverage      92%     92%   -0%     
======================================
  Files         200     200           
  Lines       12983   12983           
======================================
- Hits        11937   11897   -40     
- Misses       1046    1086   +40     

@Borda Borda requested a review from edenlightning as a code owner May 6, 2021 21:48
@Borda Borda enabled auto-merge (squash) May 6, 2021 21:48
@Borda Borda added the ready PRs ready to be merged label May 6, 2021
@lexierule lexierule disabled auto-merge May 6, 2021 23:06
@lexierule lexierule merged commit 28103c6 into master May 6, 2021
@lexierule lexierule deleted the docs/chlog branch May 6, 2021 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation related ready PRs ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants