Skip to content

Conversation

Borda
Copy link
Member

@Borda Borda commented Mar 5, 2021

What does this PR do?

we need to reduce dependency, but still, we want to give full credit to torchtext
also as it was moved to legacy, it seems to be on a deprecation curve and we need it...
Resolves #6362
Already discussed and pre-agreed with @SeanNaren and @tchaton

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added bug Something isn't working 3rd party Related to a 3rd-party labels Mar 5, 2021
@pep8speaks
Copy link

pep8speaks commented Mar 5, 2021

Hello @Borda! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-03-05 19:43:54 UTC

@Borda Borda requested a review from a team March 5, 2021 19:02
@Borda Borda changed the title copy torchtext batch fix importing torchtext batch Mar 5, 2021
@codecov
Copy link

codecov bot commented Mar 5, 2021

Codecov Report

Merging #6365 (19de065) into master (e848542) will decrease coverage by 2%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #6365    +/-   ##
=======================================
- Coverage      93%     91%    -2%     
=======================================
  Files         161     161            
  Lines       11457   11347   -110     
=======================================
- Hits        10692   10372   -320     
- Misses        765     975   +210     

@Borda Borda enabled auto-merge (squash) March 5, 2021 19:15
@Borda Borda added this to the 1.2.x milestone Mar 5, 2021
@Borda Borda merged commit 2a3ab67 into master Mar 5, 2021
@Borda Borda deleted the req/torchtext branch March 5, 2021 20:39
@tchaton tchaton mentioned this pull request Mar 8, 2021
tchaton pushed a commit that referenced this pull request Mar 9, 2021
* copy torchtext batch

* update

* rev

* rev
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3rd party Related to a 3rd-party bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ImportError: cannot import name 'Batch' from 'torchtext.data' - pytorch 1.8 and torchtext 0.9
5 participants