Typing for tests 1/n

[Borda]

What does this PR do?

add typing for test parameterization so it is easier to read and validate paraeters

Before submitting

• Was this discussed/approved via a GitHub issue? (not for typos and docs)
• Did you read the contributor guideline, Pull Request section?
• Did you make sure your PR does only one thing, instead of bundling different changes together?
• Did you make sure to update the documentation with your changes? (if necessary)
• Did you write any new necessary tests? (not for typos and docs)
• Did you verify new and existing tests pass locally with your changes?
• Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

• Is this pull request ready for review? (if not, please submit in draft mode)
• Check that all items from Before submitting are resolved
• Make sure the title is self-explanatory and the description concisely explains the PR
• Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

[codecov]

Codecov Report

Merging #6313 (93f55b7) into master (fc6d402) will decrease coverage by 0%.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #6313   +/-   ##
======================================
- Coverage      94%     94%   -0%     
======================================
  Files         161     161           
  Lines       11495   11495           
======================================
- Hits        10781   10751   -30     
- Misses        714     744   +30     

[carmocca]

I don't see the point of annotating tests, we will never check them with mypy and if they didn't work they would fail...

Our efforts would be better spent annotating the codebase or fixing stuff

[Borda]

I don't see the point of annotating tests, we will never check them with mypy and if they didn't work they would fail...

Our efforts would be better spent annotating the codebase or fixing stuff

ok, I agree that there is no point in adding more typing, just found it easier to read the test, and anyway we need to refactor our testing...

[tchaton]

LGTM !