Skip to content

[bugfix] Check LightningOptimizer doesn't delete optimizer hooks #6305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 4, 2021

Conversation

tchaton
Copy link
Contributor

@tchaton tchaton commented Mar 2, 2021

What does this PR do?

This PR adds a test to make sure hooks aren't Optimizer being deleted when LightningOptimizer is deleted

Fixes #5131

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@tchaton tchaton added the bug Something isn't working label Mar 2, 2021
@tchaton tchaton added this to the 1.2.x milestone Mar 2, 2021
@tchaton tchaton self-assigned this Mar 2, 2021
@codecov
Copy link

codecov bot commented Mar 2, 2021

Codecov Report

Merging #6305 (0835fa2) into master (6470a65) will decrease coverage by 4%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #6305    +/-   ##
=======================================
- Coverage      93%     90%    -4%     
=======================================
  Files         161     160     -1     
  Lines       11344   11691   +347     
=======================================
- Hits        10565   10476    -89     
- Misses        779    1215   +436     

@tchaton tchaton enabled auto-merge (squash) March 2, 2021 20:52
@carmocca carmocca added the ready PRs ready to be merged label Mar 3, 2021
@Borda Borda force-pushed the bugfix/5131_del_optimizer branch from 0835fa2 to 44f2c3b Compare March 4, 2021 19:50
@tchaton tchaton merged commit 7acbd65 into master Mar 4, 2021
@tchaton tchaton deleted the bugfix/5131_del_optimizer branch March 4, 2021 20:12
@tchaton tchaton mentioned this pull request Mar 8, 2021
tchaton added a commit that referenced this pull request Mar 9, 2021
Borda pushed a commit that referenced this pull request Mar 9, 2021
tchaton added a commit that referenced this pull request Mar 9, 2021
tchaton added a commit that referenced this pull request Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updating 1.0.3 -> 1.0.4 breaks pytorch module hooks
4 participants