Skip to content

Conversation

@matsumotosan
Copy link
Contributor

@matsumotosan matsumotosan commented Nov 13, 2025

What does this PR do?

Fixes part of #21304 and #21363

  • only add Python 3.13 to CI for now as it introduced some errors in CI
  • can add Python 3.14 in a separate PR
Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--21360.org.readthedocs.build/en/21360/

@github-actions github-actions bot added the ci Continuous Integration label Nov 13, 2025
@codecov
Copy link

codecov bot commented Nov 13, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
3246 1 3245 518
View the top 1 failed test(s) by shortest run time
tests/tests_pytorch/strategies/test_ddp_integration_comm_hook.py::tests.tests_pytorch.strategies.test_ddp_integration_comm_hook
Stack Traces | 0s run time
strategies/test_ddp_integration_comm_hook.py:25: in <module>
    import torch.distributed.algorithms.ddp_comm_hooks.post_localSGD_hook as post_localSGD
../../.venv/lib/python3.13.../algorithms/ddp_comm_hooks/__init__.py:44: in <module>
    class DDPCommHookType(Enum):
../../.venv/lib/python3.13.../algorithms/ddp_comm_hooks/__init__.py:54: in DDPCommHookType
    ALLREDUCE = partial(_ddp_comm_hook_wrapper, comm_hook=default.allreduce_hook)
    ^^^^^^^^^
../../../...../_temp/uv-python-dir/cpython-3.13.9-linux-x86_64-gnu/lib/python3.13/enum.py:411: in __setitem__
    warnings.warn('functools.partial will be a method descriptor '
E   FutureWarning: functools.partial will be a method descriptor in future Python versions; wrap it in enum.member() if you want to preserve the old behavior

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@github-actions github-actions bot added pl Generic label for PyTorch Lightning package dependencies Pull requests that update a dependency file labels Nov 14, 2025
@matsumotosan matsumotosan changed the title [WIP]: Add Python 3.13 and 3.14 tests [WIP]: Add Python 3.13 and 3.14 to CI Nov 14, 2025
@matsumotosan matsumotosan changed the title [WIP]: Add Python 3.13 and 3.14 to CI [WIP]: Add Python 3.13 to CI Nov 14, 2025
@github-actions github-actions bot added the fabric lightning.fabric.Fabric label Nov 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Continuous Integration dependencies Pull requests that update a dependency file fabric lightning.fabric.Fabric pl Generic label for PyTorch Lightning package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant