You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Did you make sure your PR does only one thing, instead of bundling different changes together?
Did you make sure to update the documentation with your changes? (if necessary)
Did you write any new necessary tests? (not for typos and docs)
Did you verify new and existing tests pass locally with your changes?
Did you list all the breaking changes introduced by this pull request?
Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist
Is this pull request ready for review? (if not, please submit in draft mode)
Check that all items from Before submitting are resolved
Make sure the title is self-explanatory and the description concisely explains the PR
Add labels and milestones (and optionally projects) to the PR so it can be classified
Warning
This job will need to be re-run to merge your PR. If you do not have write access to the repository, you can ask Lightning-AI/lai-frameworks to re-run it. If you push a new commit, all of CI will re-trigger.
These checks are required after the changes to src/lightning/pytorch/accelerators/xla.py, src/lightning/pytorch/loggers/comet.py, src/lightning/pytorch/loggers/mlflow.py, src/lightning/pytorch/loggers/neptune.py, src/lightning/pytorch/loggers/wandb.py, src/lightning/pytorch/plugins/precision/deepspeed.py, src/lightning/pytorch/plugins/precision/xla.py, src/lightning/pytorch/strategies/deepspeed.py, src/lightning/pytorch/strategies/launchers/xla.py, src/lightning/pytorch/strategies/single_xla.py, src/lightning/pytorch/strategies/xla.py, src/lightning/pytorch/utilities/deepspeed.py, docs/source-pytorch/conf.py, .github/workflows/docs-build.yml, requirements/pytorch/base.txt.
tqdm_write = <MagicMock name='write' id='140025804981504'>
tmp_path = PosixPath('.../pytest-of-runner/pytest-0/test_tqdm_progress_bar_print0')
@mock.patch("tqdm.tqdm.write")
def test_tqdm_progress_bar_print(tqdm_write, tmp_path):
"""Test that printing in the LightningModule redirects arguments to the progress bar."""
model = PrintModel()
bar = TQDMProgressBar()
trainer = Trainer(
default_root_dir=tmp_path,
num_sanity_val_steps=0,
limit_train_batches=1,
limit_val_batches=1,
limit_test_batches=1,
limit_predict_batches=1,
max_steps=1,
callbacks=[bar],
)
trainer.fit(model)
trainer.test(model)
trainer.predict(model)
> assert tqdm_write.call_args_list == [
call("training_step", end=""),
call("validation_step", file=sys.stderr),
call("test_step"),
call("predict_step"),
]
E assert [] == [call('traini...redict_step')]
E
E Right contains 4 more items, first extra item: #x1B[0mcall(#x1B[33m'#x1B[39;49;00m#x1B[33mtraining_step#x1B[39;49;00m#x1B[33m'#x1B[39;49;00m, end=#x1B[33m'#x1B[39;49;00m#x1B[33m'#x1B[39;49;00m)#x1B[90m#x1B[39;49;00m
E
E Full diff:
E #x1B[0m#x1B[92m+ []#x1B[39;49;00m#x1B[90m#x1B[39;49;00m
E #x1B[91m- [#x1B[39;49;00m#x1B[90m#x1B[39;49;00m
E #x1B[91m- call('training_step', end=''),#x1B[39;49;00m#x1B[90m#x1B[39;49;00m
E #x1B[91m- call('validation_step', file=<_io.TextIOWrapper name="<_io.FileIO name=9 mode='rb+' closefd=True>" mode='r+' encoding='utf-8'>),#x1B[39;49;00m#x1B[90m#x1B[39;49;00m
E #x1B[91m- call('test_step'),#x1B[39;49;00m#x1B[90m#x1B[39;49;00m
E #x1B[91m- call('predict_step'),#x1B[39;49;00m#x1B[90m#x1B[39;49;00m
E #x1B[91m- ]#x1B[39;49;00m#x1B[90m#x1B[39;49;00m
callbacks/progress/test_tqdm_progress_bar.py:501: AssertionError
tqdm_write = <MagicMock name='write' id='140025799204672'>
tmp_path = PosixPath('.../pytest-of-runner/pytest-0/test_tqdm_progress_bar_print_n0')
@mock.patch("tqdm.tqdm.write")
def test_tqdm_progress_bar_print_no_train(tqdm_write, tmp_path):
"""Test that printing in the LightningModule redirects arguments to the progress bar without training."""
model = PrintModel()
bar = TQDMProgressBar()
trainer = Trainer(
default_root_dir=tmp_path,
num_sanity_val_steps=0,
limit_val_batches=1,
limit_test_batches=1,
limit_predict_batches=1,
max_steps=1,
callbacks=[bar],
devices=1,
)
trainer.validate(model)
trainer.test(model)
trainer.predict(model)
> assert tqdm_write.call_args_list == [
call("validation_step", file=sys.stderr),
call("test_step"),
call("predict_step"),
]
E assert [] == [call('valida...redict_step')]
E
E Right contains 3 more items, first extra item: #x1B[0mcall(#x1B[33m'#x1B[39;49;00m#x1B[33mvalidation_step#x1B[39;49;00m#x1B[33m'#x1B[39;49;00m, file=<_io.TextIOWrapper name=#x1B[33m"#x1B[39;49;00m#x1B[33m<_io.FileIO name=9 mode=#x1B[39;49;00m#x1B[33m'#x1B[39;49;00m#x1B[33mrb+#x1B[39;49;00m#x1B[33m'#x1B[39;49;00m#x1B[33m closefd=True>#x1B[39;49;00m#x1B[33m"#x1B[39;49;00m mode=#x1B[33m'#x1B[39;49;00m#x1B[33mr+#x1B[39;49;00m#x1B[33m'#x1B[39;49;00m encoding=#x1B[33m'#x1B[39;49;00m#x1B[33mutf-8#x1B[39;49;00m#x1B[33m'#x1B[39;49;00m>)#x1B[90m#x1B[39;49;00m
E
E Full diff:
E #x1B[0m#x1B[92m+ []#x1B[39;49;00m#x1B[90m#x1B[39;49;00m
E #x1B[91m- [#x1B[39;49;00m#x1B[90m#x1B[39;49;00m
E #x1B[91m- call('validation_step', file=<_io.TextIOWrapper name="<_io.FileIO name=9 mode='rb+' closefd=True>" mode='r+' encoding='utf-8'>),#x1B[39;49;00m#x1B[90m#x1B[39;49;00m
E #x1B[91m- call('test_step'),#x1B[39;49;00m#x1B[90m#x1B[39;49;00m
E #x1B[91m- call('predict_step'),#x1B[39;49;00m#x1B[90m#x1B[39;49;00m
E #x1B[91m- ]#x1B[39;49;00m#x1B[90m#x1B[39;49;00m
callbacks/progress/test_tqdm_progress_bar.py:528: AssertionError
ciContinuous IntegrationdependenciesPull requests that update a dependency filedocsDocumentation relatedfabriclightning.fabric.FabricplGeneric label for PyTorch Lightning package
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
justusschock
requested review from
Borda,
ethanwharris,
lantiga,
tchaton and
williamFalcon
as code owners
github-actions
bot
added
fabric
What does this PR do?
Fixes #<issue_number>
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist
📚 Documentation preview 📚: https://pytorch-lightning--21354.org.readthedocs.build/en/21354/