-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Fix mypy typing errors in strategies/fully_sharded.py #13941
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
awaelchli
merged 17 commits into
Lightning-AI:master
from
Jungwon-Lee:typing_fully_sharded
Aug 3, 2022
Merged
Fix mypy typing errors in strategies/fully_sharded.py #13941
awaelchli
merged 17 commits into
Lightning-AI:master
from
Jungwon-Lee:typing_fully_sharded
Aug 3, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
Codecov Report
@@ Coverage Diff @@
## master #13941 +/- ##
==========================================
- Coverage 80% 76% -3%
==========================================
Files 103 335 +232
Lines 6833 26379 +19546
==========================================
+ Hits 5446 20136 +14690
- Misses 1387 6243 +4856 |
awaelchli
approved these changes
Jul 30, 2022
Co-authored-by: Adrian Wälchli <[email protected]>
akihironitta
approved these changes
Jul 31, 2022
otaj
approved these changes
Aug 2, 2022
Borda
approved these changes
Aug 3, 2022
rohitgr7
approved these changes
Aug 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
code quality
community
This PR is from the community
pl
Generic label for PyTorch Lightning package
ready
PRs ready to be merged
strategy: fairscale fsdp (removed)
Fully Sharded Data Parallel
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Part of #13445.
Fix typing errors in pytorch_lightning/strategies/fully_sharded.py in issue #13445.
Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃