Skip to content

Fix mypy typing errors in strategies/fully_sharded.py #13941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Aug 3, 2022

Conversation

Jungwon-Lee
Copy link
Contributor

@Jungwon-Lee Jungwon-Lee commented Jul 30, 2022

What does this PR do?

Part of #13445.

Fix typing errors in pytorch_lightning/strategies/fully_sharded.py in issue #13445.

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Jul 30, 2022
@Jungwon-Lee Jungwon-Lee changed the title Typing fully sharded Fix mypy typing errors in pytorch_lightning/strategies/fully_sharded.py Jul 30, 2022
@Jungwon-Lee Jungwon-Lee changed the title Fix mypy typing errors in pytorch_lightning/strategies/fully_sharded.py Fix mypy typing errors in strategies/fully_sharded.py Jul 30, 2022
@codecov
Copy link

codecov bot commented Jul 30, 2022

Codecov Report

Merging #13941 (f308a1f) into master (e513638) will decrease coverage by 3%.
The diff coverage is 47%.

❗ Current head f308a1f differs from pull request most recent head 418eb82. Consider uploading reports for the commit 418eb82 to get more accurate results

@@            Coverage Diff             @@
##           master   #13941      +/-   ##
==========================================
- Coverage      80%      76%      -3%     
==========================================
  Files         103      335     +232     
  Lines        6833    26379   +19546     
==========================================
+ Hits         5446    20136   +14690     
- Misses       1387     6243    +4856     

@awaelchli awaelchli added strategy: fairscale fsdp (removed) Fully Sharded Data Parallel code quality community This PR is from the community labels Jul 30, 2022
@awaelchli awaelchli added this to the pl:1.8 milestone Jul 30, 2022
Co-authored-by: Adrian Wälchli <[email protected]>
@mergify mergify bot added the ready PRs ready to be merged label Jul 31, 2022
@otaj otaj mentioned this pull request Aug 2, 2022
52 tasks
@mergify mergify bot added has conflicts and removed ready PRs ready to be merged labels Aug 3, 2022
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Aug 3, 2022
@awaelchli awaelchli enabled auto-merge (squash) August 3, 2022 22:55
@mergify mergify bot added the ready PRs ready to be merged label Aug 3, 2022
@awaelchli awaelchli merged commit 7fe5d4b into Lightning-AI:master Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality community This PR is from the community pl Generic label for PyTorch Lightning package ready PRs ready to be merged strategy: fairscale fsdp (removed) Fully Sharded Data Parallel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants