fix mypy typing errors in pytorch_lightning/__setup__.py #13472
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes mypy typing errors in
pytorch_lightning.__setup__.py
in #13445 and propagate to other files containing the same edited code.The
AttributeError
error that would have been raised if theassert
call did not exist, does not seem to be caught elsewhere, so changing it toAssertionError
has no impact on behavior.Since the modified function
_load_py_module
is present in 4 additional files, I have copied the changes to these files as well to keep consistency.It makes sense to me to do this in one PR, If I am supposed to do this in another PR please let me know
Does your PR introduce any breaking changes? If yes, please list them.
None
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃