-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Deprecate DistributedType in favor of StrategyType
#10505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
DistributedType Enum to StrategyTypeDistributedType in favor of StrategyType
ethanwharris
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, LGTM 😃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there are still some instances of it left inside dqn example inside notebooks..
Co-authored-by: Carlos Mocholí <[email protected]>
Co-authored-by: Carlos Mocholí <[email protected]>
Co-authored-by: Carlos Mocholí <[email protected]>
for more information, see https://pre-commit.ci
|
Great! Thank you for fixing this. |
tchaton
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
Codecov Report
@@ Coverage Diff @@
## master #10505 +/- ##
=======================================
Coverage 92% 92%
=======================================
Files 179 178 -1
Lines 16288 16226 -62
=======================================
- Hits 15060 15009 -51
+ Misses 1228 1217 -11 |
What does this PR do?
Part of #9932
Kudos to @ethanwharris for sharing the Enum deprecation trick! 🥳
Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃