Skip to content

Conversation

@rohitgr7
Copy link
Contributor

What does this PR do?

Part of #10312

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@rohitgr7 rohitgr7 self-assigned this Nov 11, 2021
@rohitgr7 rohitgr7 added this to the 1.6 milestone Nov 11, 2021
@rohitgr7 rohitgr7 marked this pull request as ready for review November 12, 2021 07:05
@mergify mergify bot added the ready PRs ready to be merged label Nov 12, 2021
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@justusschock justusschock enabled auto-merge (squash) November 12, 2021 11:25
Co-authored-by: Adrian Wälchli <[email protected]>
@justusschock justusschock merged commit fa0ed17 into master Nov 12, 2021
@justusschock justusschock deleted the remove/train_loop branch November 12, 2021 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready PRs ready to be merged refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants