Skip to content

Conversation

@ninginthecloud
Copy link
Contributor

@ninginthecloud ninginthecloud commented Oct 21, 2021

What does this PR do?

Revert PR #9895

See the discussion in Issue #5965
overriding _len_ of datamodule could bring a lot of downstream problems. Let's revert this change (PR #9895 ) and discuss a better way to summarize datamodule.

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@ninginthecloud
Copy link
Contributor Author

cc: @tchaton @ananthsub @carmocca

@ninginthecloud ninginthecloud changed the title revert len(datamodule) PR 9895 revert len(datamodule) PR Oct 21, 2021
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@awaelchli awaelchli added bug Something isn't working priority: 0 High priority task labels Oct 21, 2021
@awaelchli awaelchli added this to the v1.5 milestone Oct 21, 2021
@mergify mergify bot added the ready PRs ready to be merged label Oct 21, 2021
@ananthsub ananthsub added the data handling Generic data-related topic label Oct 21, 2021
@awaelchli awaelchli enabled auto-merge (squash) October 22, 2021 04:33
@akihironitta akihironitta disabled auto-merge October 22, 2021 10:20
@akihironitta akihironitta enabled auto-merge (squash) October 22, 2021 10:21
@ninginthecloud ninginthecloud marked this pull request as draft October 27, 2021 05:53
auto-merge was automatically disabled October 27, 2021 05:53

Pull request was converted to draft

@ninginthecloud ninginthecloud force-pushed the revert/len_datamodule_9895 branch 2 times, most recently from 29ed451 to c409ae4 Compare October 27, 2021 06:17
@ninginthecloud ninginthecloud marked this pull request as ready for review October 27, 2021 07:00
@ninginthecloud ninginthecloud force-pushed the revert/len_datamodule_9895 branch from c409ae4 to e6102a9 Compare October 28, 2021 06:20
@carmocca carmocca merged commit dbfaded into Lightning-AI:master Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working data handling Generic data-related topic priority: 0 High priority task ready PRs ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants