-
Notifications
You must be signed in to change notification settings - Fork 3.6k
revert len(datamodule) PR #10072
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
carmocca
merged 1 commit into
Lightning-AI:master
from
ninginthecloud:revert/len_datamodule_9895
Oct 29, 2021
Merged
revert len(datamodule) PR #10072
carmocca
merged 1 commit into
Lightning-AI:master
from
ninginthecloud:revert/len_datamodule_9895
Oct 29, 2021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
tchaton
approved these changes
Oct 21, 2021
Contributor
tchaton
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
awaelchli
approved these changes
Oct 21, 2021
kaushikb11
approved these changes
Oct 21, 2021
ananthsub
approved these changes
Oct 21, 2021
justusschock
approved these changes
Oct 22, 2021
akihironitta
approved these changes
Oct 22, 2021
Borda
approved these changes
Oct 25, 2021
auto-merge was automatically disabled
October 27, 2021 05:53
Pull request was converted to draft
29ed451 to
c409ae4
Compare
This reverts commit 6429de8.
c409ae4 to
e6102a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
data handling
Generic data-related topic
priority: 0
High priority task
ready
PRs ready to be merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Revert PR #9895
See the discussion in Issue #5965
overriding
_len_of datamodule could bring a lot of downstream problems. Let's revert this change (PR #9895 ) and discuss a better way to summarize datamodule.Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃