Prepare for Workbench Beta Phase (update styles) #212
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These will be submitted in a separate PR
We can't use a single shebang: * on some platforms `python` may mean Python 2, on others - Python 3 * on some platforms `python3` does not exist at all Therefore, we're removing the shebangs altogether.
... for compatibility with Windows
These '2>/dev/null' are important on Windows because without them a mere `make` stalls.
…pages" This reverts commit cb78403.
I used the conversion for 1px = 0.0625em based on a default 16pt font This will address part of carpentries/styles#630
add new steps to transition lessons to Workbench
1. The transtion headers will now have a button that can close them (though its not permenent) 2. The third step of the transition will no longer be coded into the yaml here because the third step of the transition will use the workbench version as the default version. This means that no redirect will be needed. 3. All transition dates will be specified 4. Language has been updated to not refer to "Jekyll" as it may not be immediately obvious that Jekyll was used to build the site.
modify transition workflow/variables
This will fix #641
this will fix #642
Fix workflows 641
update beta phase target
Member
|
@LibraryCarpentry/lc-shell-maintainers this PR is currently blocking the lesson's entry into the Workbench beta phase (#211) - please let me or @zkamvar know if you would like any help reviewing and/or merging it. It is very large and I could definitely understand if the task seems somewhat daunting! (Incidentally, one of the big advantages of switching over to the new lesson infrastructure will be that large pull requests like this to update lesson site styling and repository mechanics will no longer be necessary.) |
zkamvar
changed the title
Contributor
Author
|
I have updated this pull request to also include the necessary information for the workbench beta phase. |
Contributor
|
merging to prepare for new workbench beta |
zkamvar
pushed a commit
that referenced
this pull request
May 8, 2023
Prepare for Workbench Beta Phase (update styles)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @LibraryCarpentry/lc-shell-maintainers,
This PR does two things:
Merging this will allow me to work on #211