Express update & fixing tests #81
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks like should.js has changed support for .include(), so this assertion won't work correctly right now.
|
This helped me run on an app running express 2.5. it would not start correctly without this patch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to hack on tobi, but the dev dependencies are pulling in a now-unpublished version of express. So I bumped that, and a bunch of tests are failing (IDK if they were failing on older versions as well).
I've fixed some of the tests, and I'm gonna hopefully go through the rest and fix them all, but feel free to merge at any time :)
To be honest, I don't completely know what I'm doing with all the code, so if you catch me doing something crazy, let me know.