DataFormModal component #5863
Open
DataFormModal component #5863
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ci skip] [skip ci]
[ci skip] [skip ci]
[ci skip] [skip ci]
…into modal-form # Conflicts: # src/CrudPanelManager.php
[ci skip] [skip ci]
tabacitu
reviewed
Sep 16, 2025
tabacitu
reviewed
Sep 16, 2025
tabacitu
requested changes
Oct 2, 2025
src/resources/views/crud/components/dataform/modal-form.blade.php
Outdated
Show resolved
Hide resolved
[ci skip] [skip ci]
tabacitu
reviewed
Oct 13, 2025
tabacitu
reviewed
Oct 13, 2025
src/resources/views/crud/components/dataform/modal-form.blade.php
Outdated
Show resolved
Hide resolved
tabacitu
reviewed
Oct 13, 2025
tabacitu
reviewed
Oct 13, 2025
tabacitu
reviewed
Oct 13, 2025
tabacitu
reviewed
Oct 13, 2025
tabacitu
reviewed
Oct 13, 2025
tabacitu
reviewed
Oct 13, 2025
There was a problem hiding this comment.
Please test the field stacks - try to push some widgets to before_content and after_content
tabacitu
reviewed
Oct 13, 2025
tabacitu
reviewed
Oct 13, 2025
tabacitu
reviewed
Oct 13, 2025
tabacitu
reviewed
Oct 13, 2025
[ci skip] [skip ci]
[ci skip] [skip ci]
tabacitu
reviewed
Oct 16, 2025
| data-has-upload-fields="{{ $hasUploadFields ? 'true' : 'false' }}" | ||
| data-refresh-datatable="{{ $refreshDatatable ? 'true' : 'false' }}" | ||
| > | ||
| <div class="text-center"> |
There was a problem hiding this comment.
Is there an elegant way for us to tell the form blade file to NOT use the card and card-body classes? Both the Dataform and DataformModal would benefit from this tiny change:
[ci skip] [skip ci]
[ci skip] [skip ci]
tabacitu
reviewed
Oct 17, 2025
There was a problem hiding this comment.
Here's another round of testing. I discovered:
- quite a few fields don't work
select2s,browse - edit modal doesn't load the entry
- after an entry is created with DataFormModal, sometimes the datatable refreshes, sometimes it doesn't
Here's a 5-min tour of my experience:
https://www.loom.com/share/6bffaa54f65e4c7f8b4188e064ca0bb7
47 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In development, this introduces a form in a modal 🙏