Refactor tests runner script to use dbus-launch instead of dbus-daemon #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors tests/run.sh to use dbus-launch instead of dbus-daemon.
dbus-launch is more suited to this task and leads to a cleaner script. Also for some reason descriptor 0 redirection to a file was not working on some systems that I have tested it on.
I know there is an ongoing effort to migrate to pytest but this fixes run.sh in the meantime.
Considering that at this moment the tests are independent from each other, dbus-run-session could be used instead to have each test launch its own dbus session (and to get it finished automatically at the end of the test), but I have kept the original approach of a common dbus session for all the tests.