fixed the ViewFieldsBindingFixture by migrating it from the deprecate…

[Krishanthaudayakumara]

…d TestServerBuilder pattern to the TestWebApplicationFactory approach

Description / Motivation

Testing

• The Unit & Intergration tests are passing.
• I have added the necessary tests to cover my changes.

Terms

• I agree to follow this project's Code of Conduct.

[Copilot]

Pull Request Overview

This PR migrates test fixtures from the deprecated TestServerBuilder pattern to the modern TestWebApplicationFactory<T> approach for integration testing. The migration updates multiple test fixtures to use a centralized factory with program classes, improving test consistency and maintainability.

Key changes:

• Replaced TestServerBuilder with TestWebApplicationFactory<T> across all integration test fixtures
• Created dedicated test program classes for different testing scenarios (tracking, binding, rendering, etc.)
• Consolidated mock HTTP client handling in the factory
• Updated test fixtures to use dependency injection through IClassFixture<T>

Reviewed Changes

Copilot reviewed 25 out of 25 changed files in this pull request and generated 10 comments.

Show a summary per file

File	Description
TestWebApplicationFactory.cs	Enhanced factory with reflection-based host creation and specialized tracking/middleware configurations
TrackingProxyFixture.cs	Migrated from TestServer to factory pattern with TestTrackingProgram
TrackingFixture.cs	Updated to use TestSimpleTrackingProgram through factory
TestTrackingProgram.cs	New program class for tracking with visitor identification middleware
TestSimpleTrackingProgram.cs	New program class for simple tracking scenarios
AttributeBasedTrackingFixture.cs	Migrated to factory pattern using TestTrackingProgram
Various test fixtures	Updated to use factory pattern with appropriate test program classes

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[Copilot]

The method invocation could return null but is cast to IHostBuilder without null checking. Add null check before casting or use a safer cast operation.

Suggested change

	return createHostBuilderMethod.Invoke(null, new object[] { Array.Empty<string>() }) as IHostBuilder;
	var result = createHostBuilderMethod.Invoke(null, new object[] { Array.Empty<string>() });
	if (result is IHostBuilder hostBuilder)
	{
	return hostBuilder;
	}
	// If the method returns null or an unexpected type, fall back to base implementation
	return base.CreateHostBuilder();

[Copilot]

Using LastOrDefault() to get the last IP from X-Forwarded-For header is incorrect. The first IP in the list represents the original client IP, not the last one.

Suggested change

	var lastIp = ips.LastOrDefault()?.Trim();
	if (!string.IsNullOrEmpty(lastIp))
	{
	message.Headers.Add("X-Forwarded-For", lastIp);
	var firstIp = ips.FirstOrDefault()?.Trim();
	if (!string.IsNullOrEmpty(firstIp))
	{
	message.Headers.Add("X-Forwarded-For", firstIp);

[Copilot]

Hard-coded string comparisons with type names are fragile and error-prone. Consider using type-based checks like typeof(T) == typeof(TestTrackingProgram) or implementing a marker interface.

Suggested change

	bool isTrackingProgram = typeof(T).Name == "TestTrackingProgram";
	bool isTrackingProgram = typeof(T) == typeof(TestTrackingProgram);

[Copilot]

Hard-coded string comparisons with type names are fragile and error-prone. Consider using type-based checks like typeof(T) == typeof(TestTrackingProgram) or implementing a marker interface.

Suggested change

	bool isTrackingProgram = typeof(T).Name == "TestTrackingProgram";
	bool isTrackingProgram = typeof(T) == typeof(TestTrackingProgram);

[Copilot]

Hard-coded string comparisons with type names are fragile and error-prone. Consider using type-based checks like typeof(T) == typeof(TestTrackingProgram) or implementing a marker interface.

[Copilot]

Calling ToString() on PathString + QueryString concatenation is unnecessary. The PathString type already handles implicit string conversion properly.

Suggested change

	var finalUrl = new Uri(visitorIdOptions.Value.SitecoreInstanceUri, fullPath.ToString());
	var finalUrl = new Uri(visitorIdOptions.Value.SitecoreInstanceUri, fullPath);

[Copilot]

Using NotImplementedException in configuration is misleading since this indicates missing functionality rather than intentional delegation. Consider using a more descriptive exception type or comment.

Suggested change

	throw new NotImplementedException("Mock handler should be configured by TestWebApplicationFactory");
	throw new InvalidOperationException("Mock handler should be configured by TestWebApplicationFactory");

[Copilot]

Using NotImplementedException in configuration is misleading since this indicates missing functionality rather than intentional delegation. Consider using a more descriptive exception type or comment.

Suggested change

	throw new NotImplementedException("Mock handler should be configured by TestWebApplicationFactory");
	throw new InvalidOperationException("Mock handler should be configured by TestWebApplicationFactory");

[Copilot]

This test implementation is incorrect. It's creating a task that always throws rather than testing actual functionality. The test should verify the real message configuration error scenario.

[Copilot]

Changed from ChildNodes.First() to Descendants().FirstOrDefault() which fundamentally alters the search behavior. This may not find the intended element if the DOM structure is different.

Suggested change

	HtmlNode? sectionNode = doc.DocumentNode.Descendants().FirstOrDefault(n => n.HasClass("component-6"));
	HtmlNode? sectionNode = doc.DocumentNode.ChildNodes.FirstOrDefault(n => n.NodeType == HtmlNodeType.Element && n.HasClass("component-6"));