Option 3 - fixed: Update date formatting tests to handle culture-specific formats

[Krishanthaudayakumara]

• Convert DateTagHelper unit tests to use InlineData pattern with multiple cultures (en-US, da-DK, uk-UA)
• Update integration tests to expect culture-aware date formatting instead of hardcoded US format
• Fix test failures when running with Danish (da-dk) culture where date separator changes from "/" to "-"
• Replace var declarations with explicit types in modified test methods
• Add System.Globalization using statements where needed

Files modified,

• DateTagHelperFixture.cs: Convert to multi-culture InlineData tests
• DateFieldTagHelperFixture.cs: Use CurrentCulture for date expectations
• AllFieldTagHelpersFixture.cs: Use CurrentCulture for date assertions
• RichTextFieldTagHelperFixture.cs: Handle culture-specific date formatting
• ViewFieldsBindingFixture.cs: Update date format expectations

[robearlam]

Why do we need to new these up when they are added to the Fixture and can be passed in like the sut was previously?

[Krishanthaudayakumara]

I have updated this to - use [InlineAutoNSubstituteData] attributes and receive dependency injected instances.

[robearlam]

Same again, these can be passed in from the fixture right?

[Krishanthaudayakumara]

I have updated this to - use [InlineAutoNSubstituteData] attributes and receive dependency injected instances.

[Copilot]

Pull Request Overview

This pull request updates date formatting tests to handle culture-specific formats, addressing test failures when running with different cultures like Danish (da-DK) where date separators change from "/" to "-".

• Converts DateTagHelper unit tests to use InlineData pattern with multiple cultures (en-US, da-DK, uk-UA)
• Updates integration tests to use CurrentCulture for date formatting instead of hardcoded US format
• Adds explicit type declarations and required using statements for System.Globalization

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
DateTagHelperFixture.cs	Converts unit tests to multi-culture InlineData pattern with explicit culture handling
RichTextFieldTagHelperFixture.cs	Updates date expectations to use CurrentCulture formatting
DateFieldTagHelperFixture.cs	Replaces hardcoded date strings with culture-aware formatting
AllFieldTagHelpersFixture.cs	Updates date field assertions to use CurrentCulture
ViewFieldsBindingFixture.cs	Modifies date format expectations to handle culture differences

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[Copilot]

The hardcoded date format 'MM/dd/yyyy H:mm' may not work correctly across all cultures being tested. Consider using culture-specific format patterns or testing with formats that are more universal across the specified cultures (en-US, da-DK, uk-UA).

Suggested change

	const string dateFormat = "MM/dd/yyyy H:mm";
	const string dateFormat = "yyyy-MM-dd HH:mm";

[Copilot]

The hardcoded date format 'MM/dd/yyyy H:mm' may not work correctly across all cultures being tested. Consider using culture-specific format patterns or testing with formats that are more universal across the specified cultures (en-US, da-DK, uk-UA).

Suggested change

	string dateFormat = "MM/dd/yyyy H:mm";
	string dateFormat = "yyyy-MM-dd HH:mm";