Skip to content

Date Format issue - option 2 - Adjust hardcoded date strings to match with culture - compare to PR opened #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: fix/date-format-culture-invariant
Choose a base branch
from
Open

Date Format issue - option 2 - Adjust hardcoded date strings to match with culture - compare to PR opened #21

wants to merge 5 commits into from

Conversation

@Krishanthaudayakumara
Copy link
Owner

@Krishanthaudayakumara Krishanthaudayakumara commented Aug 12, 2025

Description / Motivation

Testing

  • The Unit & Intergration tests are passing.
  • I have added the necessary tests to cover my changes.

Terms

@Krishanthaudayakumara
Revert "Refactor culture selection logic with formatCulture"
314a211 
This reverts commit debfcde.
@Krishanthaudayakumara
Revert "Move the formatCulture - formattedDate logic inside the terna…
03a8fd8 
…ry operator"

This reverts commit 30986a2.
@Krishanthaudayakumara
Revert "Changes on copilot review - use en-US culture for test in Dat…
781e1d8 
…eFieldTagHelperFixture.cs, extracting the culture selection logic into a separate variable for better readability in DateTagHelper.cs"

This reverts commit 979e588.
@Krishanthaudayakumara
Revert "Ensure culture-invariant date formatting for explicit formats…
f803277 
… and set test cultures"

This reverts commit ccc68c7.
@Krishanthaudayakumara
Make date field tag helper tests culture-aware - testing
c4d5106
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Krishanthaudayakumara