Fix a flaky test #4274
Merged
Fix a flaky test #4274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkhalanskyjb
force-pushed
the
dk-fix-flaky-test
branch
from
42badac to
3eaaefd
Compare
dkhalanskyjb
force-pushed
the
dk-fix-flaky-test
branch
from
3eaaefd to
a4dc964
Compare
Follow-up for #4227 This time, the fix is less likely to work just by accident. With enough loop iterations if we close the pool after each iteration, the current `develop` fails in 10/10 runs, whereas after this fix, running the test for 20 runs didn't fail once.
dkhalanskyjb
force-pushed
the
dk-fix-flaky-test
branch
from
a4dc964 to
aa7a4fd
Compare
qwwdfsad
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up for #4227
This time, the fix is less likely to work just by accident. With enough loop iterations if we close the pool
after each iteration, the current
developfails in 10/10 runs, whereas after this fix, running the test for 20 runs didn't fail once.