Replace a usage of deprecated getTimeNanos() in K/N #4238
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qurbonzoda
commented
Sep 27, 2024
woainikk
approved these changes
Sep 27, 2024
qurbonzoda
added
the
kotlin-merge-blocker
qurbonzoda
commented
Oct 3, 2024
qurbonzoda
commented
Oct 3, 2024
qurbonzoda
commented
Oct 3, 2024
whyoleg
reviewed
Oct 3, 2024
qurbonzoda
commented
Oct 4, 2024
dkhalanskyjb
requested changes
Oct 4, 2024
dkhalanskyjb
approved these changes
Oct 7, 2024
The function was deprecated with warning in Kotlin 1.9. In Kotlin 2.1 the deprecation level will be raised to error. See KT-71628
qurbonzoda
force-pushed
the
qurbonzoda/fix-aggregate-build
branch
from
134a9c8 to
4c9ffd2
Compare
qurbonzoda
changed the title
ilya-g
reviewed
Oct 8, 2024
| internal actual fun nanoTime(): Long = getTimeNanos() | ||
| private val startingPoint = TimeSource.Monotonic.markNow() | ||
|
|
||
| internal actual fun nanoTime(): Long = (TimeSource.Monotonic.markNow() - startingPoint).inWholeNanoseconds |
There was a problem hiding this comment.
Tip: You could use startingPoint.elapsedNow instead of subtracting marks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function was deprecated with warning in Kotlin 1.9. In Kotlin 2.1 the deprecation level will be raised to error.
See KT-71628