Skip to content

Implemented the use of the full path to the project #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 26, 2022
Merged

Implemented the use of the full path to the project #163

merged 2 commits into from
Apr 26, 2022

Conversation

shanshin
Copy link
Collaborator

Fixes #151

@shanshin shanshin added this to the Release 0.5.1 milestone Apr 13, 2022
@shanshin shanshin requested a review from qwwdfsad April 13, 2022 11:01
qwwdfsad
qwwdfsad requested changes Apr 18, 2022
View reviewed changes
Copy link
Member

@qwwdfsad qwwdfsad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, it would be nice to have a test for that

@shanshin shanshin requested a review from qwwdfsad April 25, 2022 05:27
@shanshin
Copy link
Collaborator Author

Also, it would be nice to have a test for that

MultiProjectTests#testDisableSubproject and MultiProjectTests#testDisableSubprojectByPath

qwwdfsad
qwwdfsad requested changes Apr 25, 2022
View reviewed changes
@shanshin shanshin changed the title Implemented the use of the full path to the project instead of the name Implemented the use of the full path to the project Apr 26, 2022
@shanshin shanshin requested a review from qwwdfsad April 26, 2022 01:47
qwwdfsad
qwwdfsad approved these changes Apr 26, 2022
View reviewed changes
Copy link
Member

@qwwdfsad qwwdfsad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@shanshin shanshin merged commit 756d837 into main Apr 26, 2022
@shanshin shanshin deleted the project-names branch April 26, 2022 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qwwdfsad qwwdfsad qwwdfsad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release 0.5.1
Development

Successfully merging this pull request may close these issues.

Incorrect gradle project analysis on multi-module projects when subprojects have the same name
2 participants
@shanshin @qwwdfsad