Overload IOException constructor #276
Conversation
| public actual constructor(message: String?) : this(message, null) | ||
|
|
||
| public actual constructor() : this(null) | ||
| public actual constructor(cause: Throwable?) : this(null, cause) |
There was a problem hiding this comment.
The usual behavior of this exception constructor is this(cause?.toString(), cause).
There was a problem hiding this comment.
I'd say it should be super(cause), and all other ctors should delegate to super ctors too.
Like here https://github.com/JetBrains/kotlin/blob/master/libraries/stdlib/wasm/src/kotlin/Exceptions.kt
There was a problem hiding this comment.
Secondary constructors call this for the primary constructor here, and this delegates to super, so we can't call super directly.
If we have to migrate the style to delegate to call supers, it would be great to address the fix to a follow-up, and remove primary constructors.
There was a problem hiding this comment.
Yeap, we need to get rid of the primary ctor. I believe it could be done here along other changes, but don't mind making the change separately.
There was a problem hiding this comment.
I'll send a new PR after this gets merged.
|
@Goooler thanks for opening the PR! |
Goooler
force-pushed
the
overload-io-exception
branch
from
4ec4006 to
388d25e
Compare
|
Thank you @Goooler! |
3 participants
Closes #271.