Skip to content

Conversation

whyoleg
Copy link
Contributor

@whyoleg whyoleg commented Feb 29, 2024

Fixes #147

Note: using applyDefaultHierarchyTemplate with extended hierarchy is experimental + accessors for WasmJs and WasmWasi will be available only in KGP 2.0.

Feel free to integrate it now or wait when above points will be resolved.

Minor additional changes:

  • remove IR in JS target, as it's default now
  • minor changes to use nicer APIs for js testTasks and sourceSet dependencies
  • group native targets declaration by platform, to better understand which targets are enabled - maybe it's fine to even inline nativeTargets function, so that all targets will be in one place

* remove `IR` in JS target, as it's default now
* additional minor changes to use nicer APIs for js testTasks and sourceSet dependencies
* group native targets declaration by platform, to better understand which targets are enabled - maybe it's fine to even inline `nativeTargets` function, so that all targets will be in one place
@whyoleg whyoleg requested a review from fzhinkin February 29, 2024 18:04
@whyoleg whyoleg self-assigned this Feb 29, 2024
Copy link
Collaborator

@fzhinkin fzhinkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @whyoleg, thanks for taking care of it!

@whyoleg whyoleg merged commit 1d8e270 into develop Mar 1, 2024
@whyoleg whyoleg deleted the whyoleg/targetHierarchy branch March 1, 2024 11:14
@fzhinkin fzhinkin linked an issue Mar 14, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use default target hierarchy to setup build targets

2 participants