Skip to content

Conversation

whyoleg
Copy link
Contributor

@whyoleg whyoleg commented Feb 12, 2025

No description provided.

@whyoleg whyoleg self-assigned this Feb 12, 2025
@whyoleg whyoleg marked this pull request as draft February 12, 2025 11:27
@whyoleg whyoleg changed the base branch from master to latest-release February 12, 2025 11:35
@whyoleg whyoleg changed the base branch from latest-release to master February 12, 2025 11:35
@zoobestik zoobestik force-pushed the whyoleg/dokka2-sync branch from 83f3c78 to 449fbaf Compare April 8, 2025 12:19
@whyoleg whyoleg changed the title [DONT MERGE] Update to Dokka 2.0.0 Update to Dokka 2.0.0 Apr 9, 2025
@whyoleg whyoleg requested a review from dkhalanskyjb April 9, 2025 09:57
@whyoleg whyoleg marked this pull request as ready for review April 9, 2025 09:58
@whyoleg
Copy link
Contributor Author

whyoleg commented Apr 9, 2025

(please don't delete whyoleg/dokka2-sync branch for some time until we finalize deployment changes)

Comment on lines 386 to 388
dokkaSourceSets.named("commonMain") {
samples.from(kotlin.sourceSets.commonTest.map { it.kotlin.srcDirs })
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even though we don't have them now, we could add samples to our platform-specific declarations as well. Can this ability be preserved without specifying every source set explicitly?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, sure! I will update the PR!

@whyoleg whyoleg merged commit 7380325 into master Apr 9, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants