Update gradle version to 8.1 #319
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvicsokolova
force-pushed
the
update-gradle-8.1
branch
from
ecebf6a to
860e398
Compare
* Removed deprecated experimentalWarning from kotlinDslOptions * Manually set jvmToolChain(8) for JVM target compatibility in subprojects
mvicsokolova
force-pushed
the
update-gradle-8.1
branch
from
860e398 to
964a800
Compare
fzhinkin
reviewed
Jun 28, 2023
atomicfu-gradle-plugin/build.gradle
Outdated
| } | ||
| } | ||
|
|
||
| kotlin { |
There was a problem hiding this comment.
Replacing
sourceCompatibility = JavaVersion.VERSION_1_8
targetCompatibility = JavaVersion.VERSION_1_8
with
toolchain {
languageVersion.set(JavaLanguageVersion.of(8))
}
in the root build.gradle file should solve the issue without specifying jvmToolchain for each individual plugin.
| zipStoreBase=GRADLE_USER_HOME | ||
| zipStorePath=wrapper/dists | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-7.3-all.zip | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-8.1-all.zip |
There was a problem hiding this comment.
What's the reason for updating the version?
There was a problem hiding this comment.
The reason is preparation of kotlinx.atomicfu for K2. Expected Gradle version to be compatible with K2 is 8.3, so we decided to steadily update Gradle version first on develop and then try out the 8.3-nightly version in the kotlin-community/k2/dev branch.
There was a problem hiding this comment.
Could you please mention that in the commit message when merging the PR? Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated gradle to 8.1
jvmToolChain(8)for JVM target compatibility in all subprojects, because for some reason this config was not enough and the build was failing with errors like this: