Add initial support for CS DSL in the compiler plugin #783
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…olver to further support CS DSL
koperagen
force-pushed
the
plugin-column-selection-dsl
branch
from
261de17 to
e6b4152
Compare
|
Generated sources will be updated after merging this PR. |
zaleslaw
reviewed
Jul 16, 2024
zaleslaw
reviewed
Jul 16, 2024
|
|
||
| override fun Arguments.interpret(): PluginDataFrameSchema { | ||
| val grouped = groupImpl(receiver.df.columns(), receiver.columns.mapTo(mutableSetOf()) { it.path.path }, column) | ||
| val grouped = groupImpl(receiver.df.columns(), receiver.columns.resolve(receiver.df).mapTo(mutableSetOf()) { it.path.path }, column) |
There was a problem hiding this comment.
that is reciever.df here?
There was a problem hiding this comment.
Given this call:
df.group { a }.into("abc")
receiver = df.group { a }. Because it's a function call, its result is also interpreted. It becames GroupClauseApproximation, and so receiver.df is df.group { a }
Receiver is a special name for "this"
zaleslaw
reviewed
Jul 16, 2024
plugins/kotlin-dataframe/src/org/jetbrains/kotlinx/dataframe/plugin/loadInterpreter.kt
Show resolved
Hide resolved
zaleslaw
approved these changes
Jul 16, 2024
Jolanrensen
added
the
Compiler plugin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.