Ensure a predictable order of columns after aggregation of GroupBy
#1110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koperagen
added
the
Compiler plugin
koperagen
changed the title
GroupByGroupBy
Jolanrensen
reviewed
Mar 27, 2025
|
|
||
| res.columnsCount() shouldBe typed.columnsCount() + 1 | ||
| res.getColumnIndex("earliest") shouldBe typed.getColumnIndex("items") + 1 | ||
| withClue(res.columnNames() to typed.columnNames()) { |
There was a problem hiding this comment.
wow what is this magic :o
There was a problem hiding this comment.
It's a kotest utility. When assertion fails, it'll also print a "clue". In this case pair of lists
So instead of vague
4 should be 5
You get
[a, b, c, d], [a, b, c, c1, d]
4 should be 5
Jolanrensen
approved these changes
Mar 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to match the order of columns in the runtime and in compiler plugin
GroupBy with the same schema should give the same result after aggregation, no matter how it was created
We cannot track position of group in original df, so we align
asGroupBywithgroupByand movegroupcolumn to end