-
Notifications
You must be signed in to change notification settings - Fork 75
Closed
Labels
csvCSV / delim related issuesCSV / delim related issuesenhancementNew feature or requestNew feature or request
Milestone
Description
In the current situation, this is what the family of functions look like:
public fun DataFrame.Companion.readDelimStr(
text: String,
delimiter: Char = DELIM_DELIMITER,
header: List<String> = HEADER,
hasFixedWidthColumns: Boolean = HAS_FIXED_WIDTH_COLUMNS,
fixedColumnWidths: List<Int> = FIXED_COLUMN_WIDTHS,
colTypes: Map<String, ColType> = COL_TYPES,
skipLines: Long = SKIP_LINES,
readLines: Long? = READ_LINES,
parserOptions: ParserOptions? = PARSER_OPTIONS,
ignoreEmptyLines: Boolean = IGNORE_EMPTY_LINES,
allowMissingColumns: Boolean = ALLOW_MISSING_COLUMNS,
ignoreExcessColumns: Boolean = IGNORE_EXCESS_COLUMNS,
quote: Char = QUOTE,
ignoreSurroundingSpaces: Boolean = IGNORE_SURROUNDING_SPACES,
trimInsideQuoted: Boolean = TRIM_INSIDE_QUOTED,
parseParallel: Boolean = PARSE_PARALLEL,
): DataFrame<*>
public fun DataFrame.Companion.readDelim(
path: Path,
delimiter: Char = DELIM_DELIMITER,
header: List<String> = HEADER,
hasFixedWidthColumns: Boolean = HAS_FIXED_WIDTH_COLUMNS,
fixedColumnWidths: List<Int> = FIXED_COLUMN_WIDTHS,
compression: Compression<*> = Compression.of(path), // not present for readDelimStr
colTypes: Map<String, ColType> = COL_TYPES,
skipLines: Long = SKIP_LINES,
readLines: Long? = READ_LINES,
parserOptions: ParserOptions? = PARSER_OPTIONS,
ignoreEmptyLines: Boolean = IGNORE_EMPTY_LINES,
allowMissingColumns: Boolean = ALLOW_MISSING_COLUMNS,
ignoreExcessColumns: Boolean = IGNORE_EXCESS_COLUMNS,
quote: Char = QUOTE,
ignoreSurroundingSpaces: Boolean = IGNORE_SURROUNDING_SPACES,
trimInsideQuoted: Boolean = TRIM_INSIDE_QUOTED,
parseParallel: Boolean = PARSE_PARALLEL,
): DataFrame<*>
However, you can see that compression
is somewhere in the middle. Most likely because I removed it for the str
cases. It better be moved towards the end so users can switch between the -str overloads and the normal ones more easily.
Metadata
Metadata
Assignees
Labels
csvCSV / delim related issuesCSV / delim related issuesenhancementNew feature or requestNew feature or request