Skip to content

update form pvlib's master #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 18, 2017
Merged

update form pvlib's master #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ffd8f35
remove unused tmy._recolumn 'inplace' kwarg
KonstantinTr Oct 17, 2017
72a7144
finalize 0.5.1 whatsnew (#385)
wholmgren Oct 17, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 25 additions & 25 deletions docs/sphinx/source/whatsnew/v0.5.1.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,26 +1,13 @@
.. _whatsnew_0510:

v0.5.1 (?, 2017)
------------------------
v0.5.1 (October 17, 2017)
-------------------------

API Changes
~~~~~~~~~~~
*

Bug fixes
~~~~~~~~~
* Remove condition causing Overflow warning from clearsky.haurwitz
* modelchain.basic_chain now correctly passes 'solar_position_method'
arg to solarposition.get_solarposition
* Fixed: `Variables and Symbols extra references not available <https://github.com/pvlib/pvlib-python/issues/380>`_
* Removed unnecessary calculations of alpha_prime in spa.solar_position_numpy
and spa.solar_position_loop
* Fixed args mismatch for solarposition.pyephem call
from solarposition.get_solarposition with method='pyephem'
arg to solarposition.get_solarposition (:issue:`370`)
* ModelChain.prepare_inputs and ModelChain.complete_irradiance now
correctly pass the 'solar_position_method' argument to
solarposition.get_solarposition (:issue:`377`)
* `pvsystem.v_from_i` and `pvsystem.i_from_v` functions now accept
resistance_series = 0 and/or resistance_shunt = numpy.inf as inputs
(:issue:`340`)

Enhancements
~~~~~~~~~~~~
Expand All @@ -32,18 +19,30 @@ Enhancements
resistance_series and/or resistance_shunt may still cause issues with the
implicit solver (:issue:`340`)

API Changes
~~~~~~~~~~~
* `pvsystem.v_from_i` and `pvsystem.i_from_v` functions now accept
resistance_series = 0 and/or resistance_shunt = numpy.inf as inputs
(:issue:`340`)
Bug fixes
~~~~~~~~~
* Remove condition causing Overflow warning from clearsky.haurwitz
(:issue:`363`)
* modelchain.basic_chain now correctly passes 'solar_position_method'
arg to solarposition.get_solarposition (:issue:`370`)
* Fixed: `Variables and Symbols extra references not available
<https://github.com/pvlib/pvlib-python/issues/380>`_ (:issue:`380`)
* Removed unnecessary calculations of alpha_prime in spa.solar_position_numpy
and spa.solar_position_loop (:issue:`366`)
* Fixed args mismatch for solarposition.pyephem call
from solarposition.get_solarposition with method='pyephem'
arg to solarposition.get_solarposition (:issue:`370`)
* ModelChain.prepare_inputs and ModelChain.complete_irradiance now
correctly pass the 'solar_position_method' argument to
solarposition.get_solarposition (:issue:`377`)
* Fixed usage of inplace parameter for tmy._recolumn (:issue:`342`)

Documentation
~~~~~~~~~~~~~
* Doc string of modelchain.basic_chain was updated to describe args
more accurately
more accurately. (:issue:`370`)
* Doc strings of `singlediode`, `pvsystem.v_from_i`, and `pvsystem.i_from_v`
were updated to describe acceptable input arg ranges
were updated to describe acceptable input arg ranges. (:issue:`340`)

Testing
~~~~~~~
Expand All @@ -57,3 +56,4 @@ Contributors
* KonstantinTr
* Will Holmgren
* Mark Campanelli
* DaCoEx
6 changes: 3 additions & 3 deletions pvlib/tmy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@ def readtmy3(filename=None, coerce_year=None, recolumn=True):
index_col='datetime')

if recolumn:
_recolumn(data) # rename to standard column names
data = _recolumn(data) # rename to standard column names

data = data.tz_localize(int(meta['TZ']*3600))

Expand All @@ -213,7 +213,7 @@ def _parsedate(ymd, hour, year=None):
return true_date


def _recolumn(tmy3_dataframe, inplace=True):
def _recolumn(tmy3_dataframe):
"""
Rename the columns of the TMY3 DataFrame.

Expand Down Expand Up @@ -251,7 +251,7 @@ def _recolumn(tmy3_dataframe, inplace=True):

mapping = dict(zip(raw_columns.split(','), new_columns))

return tmy3_dataframe.rename(columns=mapping, inplace=True)
return tmy3_dataframe.rename(columns=mapping)


def readtmy2(filename):
Expand Down