Skip to content

Add tests for notification by id #490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Dec 21, 2016
Merged

Add tests for notification by id #490

Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1c851d2
Add tests for notification by id
m1guelpf Dec 21, 2016
5a9ebd4
Syntax
m1guelpf Dec 21, 2016
ac6e1cd
Fix URL
m1guelpf Dec 21, 2016
aaeee89
Generate random id
m1guelpf Dec 21, 2016
36f6e9a
Apply fixes from StyleCI
m1guelpf Dec 21, 2016
5d4da3f
Fixes
m1guelpf Dec 21, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions test/Github/Tests/Api/NotificationTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,17 @@ public function shouldMarkNotificationsAsReadForGivenDate()

$api->markRead($since);
}
public function shouldGetNotification()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add blank line between functions

{
$id = mt_rand(1, time());
;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove extra semicolon.

$api = $this->getApiMock();
$api->expects($this->once())
->method('get')
->with('/notification/'.$id);

$api->id($id);
}

/**
* @return string
Expand Down