Implemented notifications from github API #238
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/Github/Client.php
Outdated
There was a problem hiding this comment.
This is wrong. If it is in the Activity subnamespace, it should be acess from an Api\Activity API, not from the main client, to be consistent with the current architecture of the library
There was a problem hiding this comment.
Moved to namespace Api\Notification see 300a091
lib/Github/Api/Notification.php
Outdated
There was a problem hiding this comment.
typehinting the interface means that it is not compatible with PHP 5.3 or 5.4
|
Tests are missing |
|
Added test and fixed PHP5.3 and 5.4 compatibility. |
lib/Github/Api/Notification.php
Outdated
There was a problem hiding this comment.
The a should be removed here.
pilot
added a commit
that referenced
this pull request
Feb 18, 2015
Implemented notifications from github API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.