Skip to content

Switch from deprecated team member API to team memberships API #209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 22, 2014

Conversation

skwashd
Copy link
Contributor

@skwashd skwashd commented Nov 16, 2014

No description provided.

@skwashd
Copy link
Contributor Author

skwashd commented Nov 16, 2014

The old addMember() calls fail if the user isn't an existing member of the organisation. See https://developer.github.com/changes/2014-09-23-one-more-week-before-the-add-team-member-api-breaking-change/ for more info.

I didn't rename the methods so this would be a drop in change.

@skwashd
Copy link
Contributor Author

skwashd commented Nov 16, 2014

The travis fail was because the PHP 5.6 test run failed to clone the repo.

@stof
Copy link
Contributor

stof commented Dec 1, 2014

@pilot any plan to merge this ?

pilot added a commit that referenced this pull request Dec 22, 2014
Switch from deprecated team member API to team memberships API
@pilot pilot merged commit c4fb5fe into KnpLabs:master Dec 22, 2014
@pilot
Copy link
Contributor

pilot commented Dec 22, 2014

ou guys, sorry just note this PR

@skwashd good job!

@stof thanks for mention

@skwashd skwashd deleted the memberships-api branch December 23, 2014 01:42
@skwashd skwashd restored the memberships-api branch December 23, 2014 01:43
@skwashd skwashd deleted the memberships-api branch June 23, 2015 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants