adding code_with_match (#1024)

[QuentinRa]

Hi! As described in #1024, I added a function code_with_match.

[acrobat]

Thanks for the PR @QuentinRa! Few minor comments and can you add a test for this method? See the related code search for a test example

php-github-api/test/Github/Tests/Api/SearchTest.php

Lines 93 to 111 in de92500

	/**
	* @test
	*/
	public function shouldSearchCodeByQuery()
	{
	$expectedArray = [['total_count' => '0']];
	$api = $this->getApiMock();
	$api->expects($this->once())
	->method('get')
	->with(
	'/search/code',
	['q' => 'query text', 'sort' => 'updated', 'order' => 'desc']
	)
	->will($this->returnValue($expectedArray));
	$this->assertEquals($expectedArray, $api->code('query text'));
	}

[acrobat]

Suggested change

	public function code_with_match($q, $sort = 'updated', $order = 'desc')
	public function codeWithMatch(string $q, string $sort = 'updated', string $order = 'desc')

Also remove the redundant phpdoc after this change

     * @param string $q     the filter
     * @param string $sort  the sort field
     * @param string $order asc/desc

[acrobat]

Update the method after the change below

[QuentinRa]

Thanks! I looked for tests, and for CONTRIBUTING.md/code_style.*, but I haven't found any (I should've checked by myself, instead of relying on my IDE 😖).

I added the return type too. I'm not sure if I should remove the "redundant" types in the DOC, my IDE is showing a warning 😶"Update PHPDoc comment - Argument type do not match the declared type" (PHPStorm).

I'm not sure if my tests are what you wanted, I can't run them at all (and I don't have much time to look into it).

[acrobat]

I comment left based on the failing phpstan run. Otherwise the PR is good to go!

[acrobat]

Please remove these phpdocs as the are redundant with the added typehint's

[acrobat]

Thanks @QuentinRa! And congrats on your first contribution! 🎉