Allow costume accept headers for GraphQL Endpoint. #1001
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Github has multiple different accept headers for different purposes. Currently, there's no easy way to add/remove the `Accept` header to the client. ref: https://docs.github.com/en/graphql/overview/schema-previews
acrobat
requested changes
Apr 29, 2021
There was a problem hiding this comment.
@Necmttn the change looks good! Can you just add an example (so users know this "feature" exists) to switch the accept header in the graphql docs? Thanks!
See: https://github.com/KnpLabs/php-github-api/blob/master/doc/graphql.md
|
@acrobat updated 🍻 |
staabm
reviewed
Apr 29, 2021
acrobat
requested changes
Apr 29, 2021
Co-authored-by: Markus Staab <[email protected]>
Co-authored-by: Jeroen Thora <[email protected]>
acrobat
approved these changes
Apr 30, 2021
|
Thanks @Necmttn! And congrats on your first contribution! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Github has multiple different accept headers for different purposes. Currently, there's no easy way to add/remove the
Acceptheader to the client.ref: https://docs.github.com/en/graphql/overview/schema-previews